From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754936AbcAHMT1 (ORCPT ); Fri, 8 Jan 2016 07:19:27 -0500 Received: from mail-wm0-f45.google.com ([74.125.82.45]:37084 "EHLO mail-wm0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752795AbcAHMTZ (ORCPT ); Fri, 8 Jan 2016 07:19:25 -0500 Date: Fri, 8 Jan 2016 12:19:21 +0000 From: Matt Fleming To: Andy Shevchenko Cc: Robert Elliott , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , "x86@kernel.org" , linux-efi@vger.kernel.org, "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 4/4] x86/efi: print size and base in binary units in efi_print_memmap Message-ID: <20160108121921.GI2532@codeblueprint.co.uk> References: <1450402114-3606-1-git-send-email-elliott@hpe.com> <1450402114-3606-5-git-send-email-elliott@hpe.com> <20151221161629.GG4227@codeblueprint.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24+41 (02bc14ed1569) (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 27 Dec, at 04:35:12PM, Andy Shevchenko wrote: > On Mon, Dec 21, 2015 at 6:16 PM, Matt Fleming wrote: > >> diff --git a/arch/x86/platform/efi/efi.c b/arch/x86/platform/efi/efi.c > >> index 635a955..030ba91 100644 > >> --- a/arch/x86/platform/efi/efi.c > >> +++ b/arch/x86/platform/efi/efi.c > >> @@ -222,6 +222,25 @@ int __init efi_memblock_x86_reserve_range(void) > >> return 0; > >> } > >> > >> +char * __init efi_size_format(char *buf, size_t size, u64 bytes) > >> +{ > >> + if (!bytes || (bytes & 0x3ff)) > >> + snprintf(buf, size, "%llu B", bytes); > >> + else if (bytes & 0xfffff) > >> + snprintf(buf, size, "%llu KiB", bytes >> 10); > >> + else if (bytes & 0x3fffffff) > >> + snprintf(buf, size, "%llu MiB", bytes >> 20); > >> + else if (bytes & 0xffffffffff) > >> + snprintf(buf, size, "%llu GiB", bytes >> 30); > >> + else if (bytes & 0x3ffffffffffff) > >> + snprintf(buf, size, "%llu TiB", bytes >> 40); > >> + else if (bytes & 0xfffffffffffffff) > >> + snprintf(buf, size, "%llu PiB", bytes >> 50); > >> + else > >> + snprintf(buf, size, "%llu EiB", bytes >> 60); > >> + return buf; > > For me it looks like ffs with name in the table can be used. Could you provide a patch?