From: Bjorn Helgaas <helgaas@kernel.org>
To: Tim Sander <tim@krieglstein.org>
Cc: linux-kernel@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org,
Alex Williamson <alex.williamson@redhat.com>
Subject: Re: [PATCH] PCI: Add quirk for Lite-On IT Corp. / Plextor M6e PCI Express
Date: Fri, 8 Jan 2016 14:49:24 -0600 [thread overview]
Message-ID: <20160108204924.GK5354@localhost> (raw)
In-Reply-To: <11003431.x6xHs1WP1I@dabox>
[+cc Alex]
On Mon, Jan 04, 2016 at 05:47:14PM +0100, Tim Sander wrote:
> Hi
>
> Please consider this patch for the next release. It won't recognize my Plextor
> M6e PCIE disk without it. Please cc as i am not on the list.
>
> Signed-off-by: Tim Sander <tim@krieglstein.org>
>
> PCI: Add quirk for Lite-On IT Corp. / Plextor M6e PCI Express SSD [Marvell 88SS9183] (rev 14)
Alex?
Please use a subject line that matches the other similar commits:
247de694349c PCI: Add function 1 DMA alias quirk for Marvell 9120
c2e0fb966ad8 PCI: Add function 1 DMA alias quirk for HighPoint RocketRaid 642L
cc346a4714a5 PCI: Add function 1 DMA alias quirk for Marvell devices
> ---
> drivers/pci/quirks.c | 4 ++++
> include/linux/pci_ids.h | 3 +++
> 2 files changed, 7 insertions(+)
>
> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> index 7e32730..93ec5a02 100644
> --- a/drivers/pci/quirks.c
> +++ b/drivers/pci/quirks.c
> @@ -3620,6 +3620,10 @@ DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_TTI, 0x0642,
> DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_JMICRON,
> PCI_DEVICE_ID_JMICRON_JMB388_ESD,
> quirk_dma_func1_alias);
> +/* https://bugzilla.kernel.org/show_bug.cgi?id=42679 */
Thanks for the link. There are 126 comments on that bugzilla so far,
so it'd be nice to have a more specific pointer. I'm guessing 117
might be the relevant one, so:
https://bugzilla.kernel.org/show_bug.cgi?id=42679#c117
> +DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_LITE_ON,
> + PCI_DEVICE_ID_PLEXTOR_M6E,
> + quirk_dma_func1_alias);
>
> /*
> * Some devices DMA with the wrong devfn, not just the wrong function.
> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
> index d9ba49c..01d8041 100644
> --- a/include/linux/pci_ids.h
> +++ b/include/linux/pci_ids.h
> @@ -2501,6 +2501,9 @@
>
> #define PCI_VENDOR_ID_ASMEDIA 0x1b21
>
> +#define PCI_VENDOR_ID_LITE_ON 0x1c28
> +#define PCI_DEVICE_ID_PLEXTOR_M6E 0x0122
Since these constants are only used in one place, don't add them to
pci_ids.h (see comment at the top of this file). Just use the hex
constants directly in the quirk and include the vendor/device names in
the comment.
> #define PCI_VENDOR_ID_CIRCUITCO 0x1cc8
> #define PCI_SUBSYSTEM_ID_CIRCUITCO_MINNOWBOARD 0x0001
>
> --
> 1.9.1
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-01-08 20:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-04 16:47 [PATCH] PCI: Add quirk for Lite-On IT Corp. / Plextor M6e PCI Express Tim Sander
2016-01-08 20:49 ` Bjorn Helgaas [this message]
2016-01-08 21:15 ` Alex Williamson
2016-01-15 12:30 ` [PATCH] PCI: Add function 1 DMA alias quirk for Lite-On/Plextor M6e/Marvell 88SS9183 Tim Sander
2016-01-15 17:03 ` Alex Williamson
2016-01-19 20:37 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160108204924.GK5354@localhost \
--to=helgaas@kernel.org \
--cc=alex.williamson@redhat.com \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=tim@krieglstein.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).