From: David Miller <davem@davemloft.net>
To: mkubecek@suse.cz
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
hannes@stressinduktion.org, shannon.nelson@intel.com,
kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org,
kaber@trash.net
Subject: Re: [PATCH net] udp: disallow UFO for sockets with SO_NO_CHECK option
Date: Mon, 11 Jan 2016 17:42:05 -0500 (EST) [thread overview]
Message-ID: <20160111.174205.202764956086980022.davem@davemloft.net> (raw)
In-Reply-To: <20160111065030.F3FFCA0EF1@unicorn.suse.cz>
From: Michal Kubecek <mkubecek@suse.cz>
Date: Mon, 11 Jan 2016 07:50:30 +0100 (CET)
> Commit acf8dd0a9d0b ("udp: only allow UFO for packets from SOCK_DGRAM
> sockets") disallows UFO for packets sent from raw sockets. We need to do
> the same also for SOCK_DGRAM sockets with SO_NO_CHECK options, even if
> for a bit different reason: while such socket would override the
> CHECKSUM_PARTIAL set by ip_ufo_append_data(), gso_size is still set and
> bad offloading flags warning is triggered in __skb_gso_segment().
>
> In the IPv6 case, SO_NO_CHECK option is ignored but we need to disallow
> UFO for packets sent by sockets with UDP_NO_CHECK6_TX option.
>
> Signed-off-by: Michal Kubecek <mkubecek@suse.cz>
> Tested-by: Shannon Nelson <shannon.nelson@intel.com>
Applied and queued up for -stable, thanks Michal.
prev parent reply other threads:[~2016-01-11 22:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-11 6:50 [PATCH net] udp: disallow UFO for sockets with SO_NO_CHECK option Michal Kubecek
2016-01-11 12:19 ` Hannes Frederic Sowa
2016-01-11 22:42 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160111.174205.202764956086980022.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hannes@stressinduktion.org \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=shannon.nelson@intel.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).