From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760228AbcAKWpw (ORCPT ); Mon, 11 Jan 2016 17:45:52 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:42051 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758682AbcAKWpu (ORCPT ); Mon, 11 Jan 2016 17:45:50 -0500 Date: Mon, 11 Jan 2016 17:45:47 -0500 (EST) Message-Id: <20160111.174547.403936696977744988.davem@davemloft.net> To: manjeet.p@samsung.com Cc: paul.gortmaker@windriver.com, schmitzmic@gmail.com, geert@linux-m68k.org, nico@fluxnic.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, akhilesh.k@samsung.com, pankaj.m@samsung.com Subject: Re: [PATCH 1/1] smsc: Enabling SMSC LAN911 driver for ARM64 as well. From: David Miller In-Reply-To: <1452502945-27765-1-git-send-email-manjeet.p@samsung.com> References: <1452502945-27765-1-git-send-email-manjeet.p@samsung.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 11 Jan 2016 14:45:50 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Manjeet Pawar Date: Mon, 11 Jan 2016 14:32:25 +0530 > This patch enable network driver support for ARM64 > > Signed-off-by: Akhilesh Kumar > Signed-off-by: Manjeet Pawar There is no _WAY_ this is valid. This driver casts skb->data pointers to "u32" integers and then casts it back to a pointer and proceeds to dereference that pointer. I don't think you even looked at the build when trying to compile this on a 64-bit machine. That makes me have absolutely no confidence in the changes you submit to me.