From: Rob Herring <robh@kernel.org>
To: Yakir Yang <ykk@rock-chips.com>
Cc: Mark Yao <mark.yao@rock-chips.com>,
Heiko Stuebner <heiko@sntech.de>,
Russell King <rmk+kernel@arm.linux.org.uk>,
Philipp Zabel <p.zabel@pengutronix.de>,
Andy Yan <andy.yan@rock-chips.com>,
David Airlie <airlied@linux.ie>,
Kumar Gala <galak@codeaurora.org>,
Zheng Yang <zhengyang@rock-chips.com>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC PATCH v2 4/4] dt-bindings: add document for rk3229-hdmi
Date: Sun, 10 Jan 2016 20:06:18 -0600 [thread overview]
Message-ID: <20160111020618.GA20680@rob-hp-laptop> (raw)
In-Reply-To: <1452157511-18891-1-git-send-email-ykk@rock-chips.com>
On Thu, Jan 07, 2016 at 05:05:11PM +0800, Yakir Yang wrote:
> Signed-off-by: Yakir Yang <ykk@rock-chips.com>
> ---
> Changes in v2: None
>
> .../devicetree/bindings/display/rockchip/dw_hdmi-rockchip.txt | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/display/rockchip/dw_hdmi-rockchip.txt b/Documentation/devicetree/bindings/display/rockchip/dw_hdmi-rockchip.txt
> index 668091f..1cdc627 100644
> --- a/Documentation/devicetree/bindings/display/rockchip/dw_hdmi-rockchip.txt
> +++ b/Documentation/devicetree/bindings/display/rockchip/dw_hdmi-rockchip.txt
> @@ -2,7 +2,7 @@ Rockchip specific extensions to the Synopsys Designware HDMI
> ================================
>
> Required properties:
> -- compatible: "rockchip,rk3288-dw-hdmi";
> +- compatible: "rockchip,rk3288-dw-hdmi", "rockchip,rk3229-dw-hdmi";
> - reg: Physical base address and length of the controller's registers.
> - clocks: phandle to hdmi iahb and isfr clocks.
> - clock-names: should be "iahb" "isfr"
> @@ -15,8 +15,10 @@ Required properties:
> rk3288 platform
>
> Optional properties
> +- reg: Physical base address and length of the external HDMI PHY's registers.
This is already required...
> - ddc-i2c-bus: phandle of an I2C controller used for DDC EDID probing
> - clocks, clock-names: phandle to the HDMI CEC clock, name should be "cec"
> + phandle to the external HDMI PHY clock, name should be "extphy"
Does this change apply to rk3288 or just rk3229? If the latter, you
should make that clear. The driver needs to allow for old dtb's that
only have 1 clock.
Based on Philipp's feedback, you also need to add a phys property.
Rob
next prev parent reply other threads:[~2016-01-11 2:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-07 8:53 [RFC PATCH v2 0/4] Add RK3229 HDMI support Yakir Yang
2016-01-07 8:57 ` [RFC PATCH v2 1/4] drm: dw-hdmi: make it easy to recovery the platform data for platform driver Yakir Yang
2016-01-07 9:00 ` [RFC PATCH v2 2/4] drm: dw-hdmi: passing the "plat_data" when calling platform mode_valid Yakir Yang
2016-01-07 9:02 ` [RFC PATCH v2 3/4] drm: rockchip: hdmi: add RK3229 HDMI support Yakir Yang
2016-01-07 10:04 ` Philipp Zabel
2016-01-07 10:15 ` Yakir Yang
2016-01-07 16:50 ` Philipp Zabel
2016-01-08 9:13 ` Yakir Yang
2016-01-07 9:05 ` [RFC PATCH v2 4/4] dt-bindings: add document for rk3229-hdmi Yakir Yang
2016-01-11 2:06 ` Rob Herring [this message]
2016-01-11 3:48 ` Yakir Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160111020618.GA20680@rob-hp-laptop \
--to=robh@kernel.org \
--cc=airlied@linux.ie \
--cc=andy.yan@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=galak@codeaurora.org \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.yao@rock-chips.com \
--cc=p.zabel@pengutronix.de \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=ykk@rock-chips.com \
--cc=zhengyang@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).