From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758783AbcAKIMZ (ORCPT ); Mon, 11 Jan 2016 03:12:25 -0500 Received: from mail-wm0-f49.google.com ([74.125.82.49]:37112 "EHLO mail-wm0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758488AbcAKIMX (ORCPT ); Mon, 11 Jan 2016 03:12:23 -0500 Date: Mon, 11 Jan 2016 08:12:19 +0000 From: Lee Jones To: SF Markus Elfring Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: Re: [PATCH 2/2] mfd: smsc-ece1099: Refactoring for smsc_i2c_probe() Message-ID: <20160111081219.GT3331@x1> References: <566ABCD9.1060404@users.sourceforge.net> <5682957F.5000604@users.sourceforge.net> <56829630.6030706@users.sourceforge.net> <20160111081059.GS3331@x1> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160111081059.GS3331@x1> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Oh, the subject line is also duff. Please describe the changes properly. "refactoring X", "making changes to Y" are not good subject lines. On Mon, 11 Jan 2016, Lee Jones wrote: > On Tue, 29 Dec 2015, SF Markus Elfring wrote: > > > From: Markus Elfring > > Date: Tue, 29 Dec 2015 15:03:31 +0100 > > > > This issue was detected by using the Coccinelle software. > > > > * Let us return directly if a call of the function "devm_regmap_init_i2c" > > or "regmap_write" failed. > > > > * Delete the jump label "err" then. > > Why are you bullet pointing here? > > Just use proper sentences to tell us what's going on. > > > Signed-off-by: Markus Elfring > > --- > > drivers/mfd/smsc-ece1099.c | 9 +++------ > > 1 file changed, 3 insertions(+), 6 deletions(-) > > Code looks fine however. > > Please re-submit the set with the aforementioned changes along with my: > > Acked-by: Lee Jones > > > diff --git a/drivers/mfd/smsc-ece1099.c b/drivers/mfd/smsc-ece1099.c > > index bcac488..951333a 100644 > > --- a/drivers/mfd/smsc-ece1099.c > > +++ b/drivers/mfd/smsc-ece1099.c > > @@ -46,10 +46,8 @@ static int smsc_i2c_probe(struct i2c_client *i2c, > > } > > > > smsc->regmap = devm_regmap_init_i2c(i2c, &smsc_regmap_config); > > - if (IS_ERR(smsc->regmap)) { > > - ret = PTR_ERR(smsc->regmap); > > - goto err; > > - } > > + if (IS_ERR(smsc->regmap)) > > + return PTR_ERR(smsc->regmap); > > > > i2c_set_clientdata(i2c, smsc); > > smsc->dev = &i2c->dev; > > @@ -68,7 +66,7 @@ static int smsc_i2c_probe(struct i2c_client *i2c, > > > > ret = regmap_write(smsc->regmap, SMSC_CLK_CTRL, smsc->clk); > > if (ret) > > - goto err; > > + return ret; > > > > #ifdef CONFIG_OF > > if (i2c->dev.of_node) > > @@ -76,7 +74,6 @@ static int smsc_i2c_probe(struct i2c_client *i2c, > > NULL, NULL, &i2c->dev); > > #endif > > > > -err: > > return ret; > > } > > > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog