From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1758959AbcAKJZD (ORCPT <rfc822;w@1wt.eu>);
	Mon, 11 Jan 2016 04:25:03 -0500
Received: from mail-wm0-f52.google.com ([74.125.82.52]:33439 "EHLO
	mail-wm0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1758884AbcAKJY7 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 11 Jan 2016 04:24:59 -0500
Date: Mon, 11 Jan 2016 09:24:54 +0000
From: Lee Jones <lee.jones@linaro.org>
To: Chen-Yu Tsai <wens@csie.org>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>,
        Chen-Yu Tsai <wens@wens.tw>, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-sunxi@googlegroups.com, Hans de Goede <hdegoede@redhat.com>,
        Mark Brown <broonie@kernel.org>,
        Andy Shevchenko <andy.shevchenko@gmail.com>,
        Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH v6 5/9] mfd: axp20x: Whitespace, open parenthesis
 alignment code style fixes
Message-ID: <20160111092454.GJ14104@x1>
References: <1450283538-25067-1-git-send-email-wens@csie.org>
 <1450283538-25067-6-git-send-email-wens@csie.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1450283538-25067-6-git-send-email-wens@csie.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 17 Dec 2015, Chen-Yu Tsai wrote:

> This fixes some leftover code style issues in the axp20x core.
> 
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> ---
>  drivers/mfd/axp20x.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Acked-by: Lee Jones <lee.jones@linaro.org>

> diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c
> index 631ad64ddf69..54a00168da26 100644
> --- a/drivers/mfd/axp20x.c
> +++ b/drivers/mfd/axp20x.c
> @@ -591,14 +591,14 @@ int axp20x_match_device(struct axp20x_dev *axp20x)
>  			dev_err(dev, "Unable to match OF ID\n");
>  			return -ENODEV;
>  		}
> -		axp20x->variant = (long) of_id->data;
> +		axp20x->variant = (long)of_id->data;
>  	} else {
>  		acpi_id = acpi_match_device(dev->driver->acpi_match_table, dev);
>  		if (!acpi_id || !acpi_id->driver_data) {
>  			dev_err(dev, "Unable to match ACPI ID and data\n");
>  			return -ENODEV;
>  		}
> -		axp20x->variant = (long) acpi_id->driver_data;
> +		axp20x->variant = (long)acpi_id->driver_data;
>  	}
>  
>  	switch (axp20x->variant) {
> @@ -632,7 +632,7 @@ int axp20x_match_device(struct axp20x_dev *axp20x)
>  		return -EINVAL;
>  	}
>  	dev_info(dev, "AXP20x variant %s found\n",
> -		axp20x_model_names[axp20x->variant]);
> +		 axp20x_model_names[axp20x->variant]);
>  
>  	return 0;
>  }
> @@ -652,7 +652,7 @@ int axp20x_device_probe(struct axp20x_dev *axp20x)
>  	}
>  
>  	ret = mfd_add_devices(axp20x->dev, -1, axp20x->cells,
> -			axp20x->nr_cells, NULL, 0, NULL);
> +			      axp20x->nr_cells, NULL, 0, NULL);
>  
>  	if (ret) {
>  		dev_err(axp20x->dev, "failed to add MFD devices: %d\n", ret);

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog