From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759210AbcAKKVX (ORCPT ); Mon, 11 Jan 2016 05:21:23 -0500 Received: from mail-wm0-f54.google.com ([74.125.82.54]:38190 "EHLO mail-wm0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758191AbcAKKVV (ORCPT ); Mon, 11 Jan 2016 05:21:21 -0500 Date: Mon, 11 Jan 2016 10:21:17 +0000 From: Lee Jones To: Milo Kim Cc: robh+dt@kernel.org, j.anaszewski@samsung.com, broonie@kernel.org, devicetree@vger.kernel.org, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 6/9] mfd: add TI LMU hardware fault monitoring driver Message-ID: <20160111102117.GU14104@x1> References: <1448521025-2796-1-git-send-email-milo.kim@ti.com> <1448521025-2796-7-git-send-email-milo.kim@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1448521025-2796-7-git-send-email-milo.kim@ti.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 26 Nov 2015, Milo Kim wrote: > LM3633 and LM3697 are TI LMU MFD device. > Those devices have hardware monitoring feature which detects open or > short circuit case. > > Debugfs > ------- > Two files are created. > open_fault: check light output channel is open or not. > short_fault: check light output channel is shorted or not. > > The driver checks the status of backlight output channels. > LM3633 and LM3697 have same sequence to check channels, so common > functions are used. > ABI/testing document is also included. > > Operations > ---------- > Two devices have common control flow but register addresses are different. > The structure, 'ti_lmu_reg' is used for register configuration. > > Event notifier > -------------- > After fault monitoring is done, LMU device is reset. So backlight and > LED device should be reinitialized. It notifies an event as soon as > the monitoring is done. Then, LM3633 and LM3697 backlight and LED drivers > handle this event. > > Cc: Lee Jones > Cc: Jacek Anaszewski > Cc: Mark Brown > Cc: Rob Herring > Cc: devicetree@vger.kernel.org > Cc: linux-leds@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Milo Kim > --- > .../ABI/testing/debugfs-ti-lmu-fault-monitor | 32 ++ > drivers/mfd/Kconfig | 10 + > drivers/mfd/Makefile | 1 + > drivers/mfd/ti-lmu-fault-monitor.c | 405 +++++++++++++++++++++ I think this device is part of the MFD, rather than an MFD itself. Please relocate it to somewhere more appropriate. > 4 files changed, 448 insertions(+) > create mode 100644 Documentation/ABI/testing/debugfs-ti-lmu-fault-monitor > create mode 100644 drivers/mfd/ti-lmu-fault-monitor.c [...] -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog