From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759298AbcAKKvL (ORCPT ); Mon, 11 Jan 2016 05:51:11 -0500 Received: from mail-wm0-f65.google.com ([74.125.82.65]:33931 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750813AbcAKKvI (ORCPT ); Mon, 11 Jan 2016 05:51:08 -0500 Date: Mon, 11 Jan 2016 11:51:05 +0100 From: Ingo Molnar To: Linus Torvalds Cc: Andy Lutomirski , Oleg Nesterov , X86 ML , Dave Hansen , Borislav Petkov , Linux Kernel Mailing List , "linux-mm@kvack.org" , Brian Gerst Subject: Re: [RFC 09/13] x86/mm: Disable interrupts when flushing the TLB using CR3 Message-ID: <20160111105105.GB29448@gmail.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Linus Torvalds wrote: > >> Or is there some reason you wanted the odd flags version? If so, that > >> should be documented. > > > > What do you mean "odd"? > > It's odd because it makes no sense for non-pcid (christ, I wish Intel had just > called it "asid" instead, "pcid" always makes me react to "pci"), and I think it > would make more sense to pair up the pcid case with the invpcid rather than have > those preemption rules here. The naming is really painful, so a trivial suggestion: could we just name all the Linux side bits 'asid' or 'ctx_id' (even in x86 arch code) and only use 'PCID' nomenclature in the very lowest level code? I.e. rename pcid_live_cpus et al and most functions to the asid or ctx_id or asid naming scheme or so. That would hide most of the naming ugliness. Thanks, Ingo