From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933568AbcAKOMl (ORCPT ); Mon, 11 Jan 2016 09:12:41 -0500 Received: from lxorguk.ukuu.org.uk ([81.2.110.251]:43016 "EHLO lxorguk.ukuu.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933187AbcAKOMh (ORCPT ); Mon, 11 Jan 2016 09:12:37 -0500 Date: Mon, 11 Jan 2016 14:12:19 +0000 From: One Thousand Gnomes To: Peter Hurley Cc: Greg Kroah-Hartman , Jiri Slaby , linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 02/19] serial: 68328: Remove bogus ldisc reset Message-ID: <20160111141219.4aab2e6e@lxorguk.ukuu.org.uk> In-Reply-To: <1452494468-21359-3-git-send-email-peter@hurleysoftware.com> References: <1452400870-6005-1-git-send-email-peter@hurleysoftware.com> <1452494468-21359-1-git-send-email-peter@hurleysoftware.com> <1452494468-21359-3-git-send-email-peter@hurleysoftware.com> Organization: Intel Corporation X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.29; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 10 Jan 2016 22:40:51 -0800 Peter Hurley wrote: > As the #warning indicates, the open-coded ldisc reset was always not ok. > Not only is this code long dead, The entire 683xx port is long dead. As per the previous discussions on this the entire driver should go closely followed by the entire port. Nobody is using 683xx parts any more, and even if they did they wouldn't run a current Linux remotely usefully. Alan