From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934496AbcALJGR (ORCPT ); Tue, 12 Jan 2016 04:06:17 -0500 Received: from mail-wm0-f45.google.com ([74.125.82.45]:34980 "EHLO mail-wm0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934172AbcALJGE (ORCPT ); Tue, 12 Jan 2016 04:06:04 -0500 Date: Tue, 12 Jan 2016 09:06:00 +0000 From: Lee Jones To: SF Markus Elfring Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: Re: mfd-dm355evm_msp: One function call less in add_child() after error detection Message-ID: <20160112090600.GT19803@x1> References: <566ABCD9.1060404@users.sourceforge.net> <568284D3.3060006@users.sourceforge.net> <20160111083108.GC14104@x1> <5694BAA0.80004@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5694BAA0.80004@users.sourceforge.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 12 Jan 2016, SF Markus Elfring wrote: > >> The platform_device_put() function was called in one case by the > >> add_child() function during error handling even if the passed > >> variable "pdev" contained a null pointer. > >> > >> Implementation details could be improved by the adjustment of jump targets > >> according to the Linux coding style convention. > >> > >> This issue was detected by using the Coccinelle software. > >> > >> Signed-off-by: Markus Elfring > >> --- > >> drivers/mfd/dm355evm_msp.c | 21 ++++++++++----------- > >> 1 file changed, 10 insertions(+), 11 deletions(-) > > > > Same comments as before. > > To which comments do you refer here? > > Are you interested in any further clarification of open issues? I'm sure you'll work it out. ;) -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog