Re: [PATCH v15 02/25] tools: Make list.h self-sufficient

From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Borislav Petkov <bp@alien8.de>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	x86@kernel.org, linux-kernel@vger.kernel.org,
	live-patching@vger.kernel.org, Michal Marek <mmarek@suse.cz>,
	Peter Zijlstra <peterz@infradead.org>,
	Andy Lutomirski <luto@kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Andi Kleen <andi@firstfloor.org>, Pedro Alves <palves@redhat.com>,
	Namhyung Kim <namhyung@gmail.com>,
	Bernd Petrovitsch <bernd@petrovitsch.priv.at>,
	Chris J Arges <chris.j.arges@canonical.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Jiri Slaby <jslaby@suse.cz>
Subject: Re: [PATCH v15 02/25] tools: Make list.h self-sufficient
Date: Tue, 12 Jan 2016 11:54:06 -0300	[thread overview]
Message-ID: <20160112145406.GZ18367@kernel.org> (raw)
In-Reply-To: <20160112123540.GA22699@pd.tnic>

Em Tue, Jan 12, 2016 at 01:35:40PM +0100, Borislav Petkov escreveu:
> On Fri, Dec 18, 2015 at 06:39:16AM -0600, Josh Poimboeuf wrote:
> > Commit 7f5f873c6a07 added the use of the WRITE_ONCE macro to the kernel
> 
> nitpick: we like to do this commit quoting style:
> 
>   7f5f873c6a07 ("rculist: Use WRITE_ONCE() when deleting from reader-visible list")
> 
> Checkpatch catches that:
> 
> ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'Commit 7f5f873c6a07 ("rculist: Use WRITE_ONCE() when deleting from reader-visible list")'
> #21: 
> Commit 7f5f873c6a07 added the use of the WRITE_ONCE macro to the kernel

I'm fixing this up and taking this patch, ok?

- Arnaldo

> > version of list.h, which broke the stacktool build because the tools
> > list.h includes the kernel list.h.
> > 
> > Avoid this type of situation in the future and make list.h
> > self-sufficient by copying the kernel list.h routines directly into
> > tools list.h.
> > 
> > This is a straight copy except for adjustments to the include statements
> > and copying of the tools-specific list routines (list_del_range and
> > list_for_each_from).
> > 
> > Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
> > ---
> >  tools/include/linux/list.h | 753 ++++++++++++++++++++++++++++++++++++++++++++-
> >  1 file changed, 747 insertions(+), 6 deletions(-)
> 
> ...
> 
> -- 
> Regards/Gruss,
>     Boris.
> 
> ECO tip #101: Trim your mails when you reply.