From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755120AbcAMQsW (ORCPT ); Wed, 13 Jan 2016 11:48:22 -0500 Received: from mail-wm0-f65.google.com ([74.125.82.65]:34455 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752987AbcAMQsT (ORCPT ); Wed, 13 Jan 2016 11:48:19 -0500 Date: Wed, 13 Jan 2016 17:48:17 +0100 From: Michal Hocko To: Vladimir Davydov Cc: Andrew Morton , Johannes Weiner , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 4/7] swap.h: move memcg related stuff to the end of the file Message-ID: <20160113164817.GH17512@dhcp22.suse.cz> References: <77dd7375cd8360829093b4c347db2e557334da21.1450352792.git.vdavydov@virtuozzo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <77dd7375cd8360829093b4c347db2e557334da21.1450352792.git.vdavydov@virtuozzo.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 17-12-15 15:29:57, Vladimir Davydov wrote: > The following patches will add more functions to the memcg section of > include/linux/swap.h. Some of them will need values defined below the > current location of the section. So let's move the section to the end of > the file. No functional changes intended. > > Signed-off-by: Vladimir Davydov > Acked-by: Johannes Weiner Acked-by: Michal Hocko > --- > include/linux/swap.h | 70 ++++++++++++++++++++++++++++------------------------ > 1 file changed, 38 insertions(+), 32 deletions(-) > > diff --git a/include/linux/swap.h b/include/linux/swap.h > index 478e7dd038c7..f8fb4e06c4bd 100644 > --- a/include/linux/swap.h > +++ b/include/linux/swap.h > @@ -350,39 +350,7 @@ extern void check_move_unevictable_pages(struct page **, int nr_pages); > > extern int kswapd_run(int nid); > extern void kswapd_stop(int nid); > -#ifdef CONFIG_MEMCG > -static inline int mem_cgroup_swappiness(struct mem_cgroup *memcg) > -{ > - /* root ? */ > - if (mem_cgroup_disabled() || !memcg->css.parent) > - return vm_swappiness; > - > - return memcg->swappiness; > -} > > -#else > -static inline int mem_cgroup_swappiness(struct mem_cgroup *mem) > -{ > - return vm_swappiness; > -} > -#endif > -#ifdef CONFIG_MEMCG_SWAP > -extern void mem_cgroup_swapout(struct page *page, swp_entry_t entry); > -extern int mem_cgroup_try_charge_swap(struct page *page, swp_entry_t entry); > -extern void mem_cgroup_uncharge_swap(swp_entry_t entry); > -#else > -static inline void mem_cgroup_swapout(struct page *page, swp_entry_t entry) > -{ > -} > -static inline int mem_cgroup_try_charge_swap(struct page *page, > - swp_entry_t entry) > -{ > - return 0; > -} > -static inline void mem_cgroup_uncharge_swap(swp_entry_t entry) > -{ > -} > -#endif > #ifdef CONFIG_SWAP > /* linux/mm/page_io.c */ > extern int swap_readpage(struct page *); > @@ -561,5 +529,43 @@ static inline swp_entry_t get_swap_page(void) > } > > #endif /* CONFIG_SWAP */ > + > +#ifdef CONFIG_MEMCG > +static inline int mem_cgroup_swappiness(struct mem_cgroup *memcg) > +{ > + /* root ? */ > + if (mem_cgroup_disabled() || !memcg->css.parent) > + return vm_swappiness; > + > + return memcg->swappiness; > +} > + > +#else > +static inline int mem_cgroup_swappiness(struct mem_cgroup *mem) > +{ > + return vm_swappiness; > +} > +#endif > + > +#ifdef CONFIG_MEMCG_SWAP > +extern void mem_cgroup_swapout(struct page *page, swp_entry_t entry); > +extern int mem_cgroup_try_charge_swap(struct page *page, swp_entry_t entry); > +extern void mem_cgroup_uncharge_swap(swp_entry_t entry); > +#else > +static inline void mem_cgroup_swapout(struct page *page, swp_entry_t entry) > +{ > +} > + > +static inline int mem_cgroup_try_charge_swap(struct page *page, > + swp_entry_t entry) > +{ > + return 0; > +} > + > +static inline void mem_cgroup_uncharge_swap(swp_entry_t entry) > +{ > +} > +#endif > + > #endif /* __KERNEL__*/ > #endif /* _LINUX_SWAP_H */ > -- > 2.1.4 > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: email@kvack.org -- Michal Hocko SUSE Labs