From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752664AbcAQTb5 (ORCPT ); Sun, 17 Jan 2016 14:31:57 -0500 Received: from one.firstfloor.org ([193.170.194.197]:59652 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752584AbcAQTb4 (ORCPT ); Sun, 17 Jan 2016 14:31:56 -0500 Date: Sun, 17 Jan 2016 20:31:53 +0100 From: Andi Kleen To: Namhyung Kim Cc: Arnaldo Carvalho de Melo , Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML , David Ahern , Stephane Eranian , Andi Kleen , Wang Nan , Don Zickus , Pekka Enberg , Moinuddin Quadri Subject: Re: [RFC/PATCHSET 00/17] perf tools: Add support for hierachy view (v2) Message-ID: <20160117193153.GI4698@two.firstfloor.org> References: <1452960197-5323-1-git-send-email-namhyung@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1452960197-5323-1-git-send-email-namhyung@kernel.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 17, 2016 at 01:03:00AM +0900, Namhyung Kim wrote: > Hello, > > This is v2 attempt of my earlier patchset [1]. This patchset > implements a new feature that collects hist entries in a hierachical > manner. That means lower-level entries belong to an upper-level > entry. The entry hierachy is built on the sort keys given, so users > can set it whatever they want. It only shows top-level entries first, > and user can expand/collapse it dynamically. Thanks that's very nice. Especially for TSX profiling it was always very annoying that the other sort keys didn't actually sort. It should be very useful for LBR view too. Now we only need a better percent-limit that handles all leaves correctly... -Andi