From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933297AbcATATo (ORCPT ); Tue, 19 Jan 2016 19:19:44 -0500 Received: from LGEAMRELO11.lge.com ([156.147.23.51]:57975 "EHLO lgeamrelo11.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932414AbcATATf (ORCPT ); Tue, 19 Jan 2016 19:19:35 -0500 X-Original-SENDERIP: 156.147.1.126 X-Original-MAILFROM: namhyung@kernel.org X-Original-SENDERIP: 165.244.98.150 X-Original-MAILFROM: namhyung@kernel.org X-Original-SENDERIP: 10.177.227.17 X-Original-MAILFROM: namhyung@kernel.org Date: Wed, 20 Jan 2016 09:19:31 +0900 From: Namhyung Kim To: Arnaldo Carvalho de Melo CC: Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML , David Ahern , Stephane Eranian , Andi Kleen , Wang Nan , Don Zickus , Pekka Enberg , Moinuddin Quadri Subject: Re: [RFC/PATCHSET 00/17] perf tools: Add support for hierachy view (v2) Message-ID: <20160120001931.GA18796@sejong> References: <1452960197-5323-1-git-send-email-namhyung@kernel.org> <20160119205226.GF27085@kernel.org> MIME-Version: 1.0 In-Reply-To: <20160119205226.GF27085@kernel.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-MIMETrack: Itemize by SMTP Server on LGEKRMHUB08/LGE/LG Group(Release 8.5.3FP6|November 21, 2013) at 2016/01/20 09:19:31, Serialize by Router on LGEKRMHUB08/LGE/LG Group(Release 8.5.3FP6|November 21, 2013) at 2016/01/20 09:19:31, Serialize complete at 2016/01/20 09:19:31 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnaldo, On Tue, Jan 19, 2016 at 05:52:26PM -0300, Arnaldo Carvalho de Melo wrote: > Em Sun, Jan 17, 2016 at 01:03:00AM +0900, Namhyung Kim escreveu: > > Hello, > > > > This is v2 attempt of my earlier patchset [1]. This patchset > > implements a new feature that collects hist entries in a hierachical > > manner. That means lower-level entries belong to an upper-level > > entry. The entry hierachy is built on the sort keys given, so users > > can set it whatever they want. It only shows top-level entries first, > > and user can expand/collapse it dynamically. > > > > This time I implemented it for every output browser including TUI. > > A screenshot on TUI looks like below: > > > > For normal output: > > > > $ perf report --tui > > Samples: 3K of event 'cycles:pp', Event count (approx.): 1695979674 > > Overhead Command Shared Object Symbol > > ------------------------------------------------------------------------ > > - 7.57% swapper [kernel.vmlinux] [k] intel_idle > > intel_idle > > cpuidle_enter_state > > cpuidle_enter > > call_cpuidle > > + cpu_startup_entry > > + 1.16 firefox firefox [.] 0x00000000000019433 > > + 0.97% firefox libpthread-2.22.so [.] pthread_mutex_lock > > ... > > > > > > With hierarchy view, > > > > $ perf report --tui --hierarchy > > Samples: 3K of event 'cycles:pp', Event count (approx.): 1695979674 > > Overhead Command / Shared Object / Symbol > > ------------------------------------------------------------------- > > + 76.30% firefox > > - 9.95% swapper > > - 9.51% [kernel.vmlinux] > > - 7.57 [k] intel_idle > > intel_idle > > cpuidle_enter_state > > cpuidle_enter > > call_cpuidle > > + cpu_startup_entry > > + 0.15% [k] __schedule > > + 0.12% [k] menu_select > > ... > > + 0.34% [sdhci] > > + 0.06% [e1000e] > > ... > > + 5.65% Xorg > > + 5.42% Socket Thread > > ... > > > > As you can see, overhead of an upper level entry is the sum of > > overhead of lower level entries. The entries are aligned by its order > > of matching sort keys. > > > > This is available from 'perf/hierarchy-v2' branch in my tree: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/namhyung-perf.git > > Didn't work: > > [acme@jouet linux]$ git remote add namhyung git://git.kernel.org/pub/scm/linux/kernel/git/namhyung-perf.git > [acme@jouet linux]$ git remote update namhyung > Fetching namhyung > fatal: remote error: access denied or repository not exported: /pub/scm/linux/kernel/git/namhyung-perf.git > error: Could not fetch namhyung > [acme@jouet linux]$ > > I looked it up and this one works: > > git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git > > Doing a test merge to test this. Oops, sorry about that. I should not type it manually.. Thanks, Namhyung