From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759465AbcAUMDB (ORCPT ); Thu, 21 Jan 2016 07:03:01 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50219 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751189AbcAUMC7 (ORCPT ); Thu, 21 Jan 2016 07:02:59 -0500 Date: Thu, 21 Jan 2016 13:02:55 +0100 From: Jiri Olsa To: Namhyung Kim Cc: Arnaldo Carvalho de Melo , Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML , David Ahern , Stephane Eranian , Andi Kleen , Wang Nan Subject: Re: [PATCH v2 04.1/17] perf hists: Remove parent filter check in DSO filter function Message-ID: <20160121120255.GB11238@krava.brq.redhat.com> References: <20160119203910.GE27085@kernel.org> <1453252521-24398-1-git-send-email-namhyung@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1453252521-24398-1-git-send-email-namhyung@kernel.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 20, 2016 at 10:15:20AM +0900, Namhyung Kim wrote: > The --exclude-other option sets HIST_FILTER__PARENT bit and it's only > set when a hist entry was created. DSO filters don't change this so > no need to have the check in hists__filter_by_dso() IMHO. > > Signed-off-by: Namhyung Kim Acked-by: Jiri Olsa jirka > --- > tools/perf/util/hist.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/tools/perf/util/hist.c b/tools/perf/util/hist.c > index 9354455aec5b..7c9af05726ad 100644 > --- a/tools/perf/util/hist.c > +++ b/tools/perf/util/hist.c > @@ -1483,9 +1483,6 @@ void hists__filter_by_dso(struct hists *hists) > for (nd = rb_first(&hists->entries); nd; nd = rb_next(nd)) { > struct hist_entry *h = rb_entry(nd, struct hist_entry, rb_node); > > - if (symbol_conf.exclude_other && !h->parent) > - continue; > - > if (hists__filter_entry_by_dso(hists, h)) > continue; > > -- > 2.7.0 >