From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751139AbcAUXvl (ORCPT ); Thu, 21 Jan 2016 18:51:41 -0500 Received: from mail.kernel.org ([198.145.29.136]:48334 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750817AbcAUXvi (ORCPT ); Thu, 21 Jan 2016 18:51:38 -0500 Date: Thu, 21 Jan 2016 20:51:33 -0300 From: Arnaldo Carvalho de Melo To: Namhyung Kim Cc: Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML , David Ahern , Stephane Eranian , Andi Kleen , Wang Nan Subject: Re: [PATCH 08/17] perf hists browser: Fix context menu item Message-ID: <20160121235133.GF4034@kernel.org> References: <1452960197-5323-1-git-send-email-namhyung@kernel.org> <1452960197-5323-9-git-send-email-namhyung@kernel.org> <20160121005245.GM18367@kernel.org> <20160121040710.GC10179@sejong> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160121040710.GC10179@sejong> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Thu, Jan 21, 2016 at 01:07:10PM +0900, Namhyung Kim escreveu: > On Wed, Jan 20, 2016 at 09:52:45PM -0300, Arnaldo Carvalho de Melo wrote: > > Em Sun, Jan 17, 2016 at 01:03:08AM +0900, Namhyung Kim escreveu: > > > When symbol sort key is not given, it doesn't show any item other than > > > exit. Check sort key to select possible items. Also check items more > > > strictly using sort key information. > > So, without this patch when I press enter on 'perf top' I can zoom into > > threads, with it I lose that option. > Yes, but it was incorrect information. The default sort key of 'perf > top' doesn't contain 'comm' (or 'pid') so hist entries it shows can > have samples from different threads. The result is that it only shows > thread of the first sample of the entry. Filtering based on this > incorrect info should be avoided IMHO. Ok, agreed, but this patch is doing way too many things at once, please take a look at my current perf/core branch, it has the first few patches I carved out from this one, see if you are ok with it, will continue. And this is not hierarchy related, so will go first, as fixes in perf/core. - Arnaldo