From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755071AbcAVVb7 (ORCPT ); Fri, 22 Jan 2016 16:31:59 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:42325 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754798AbcAVVba (ORCPT ); Fri, 22 Jan 2016 16:31:30 -0500 Date: Fri, 22 Jan 2016 21:31:15 +0000 From: Mark Brown To: Joe Perches Cc: Paul Kocialkowski , Liam Girdwood , linux-kernel@vger.kernel.org Message-ID: <20160122213115.GF6588@sirena.org.uk> References: <1453407851-8039-1-git-send-email-broonie@kernel.org> <1453490128.13870.31.camel@perches.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="xwQtY96q3287+Drf" Content-Disposition: inline In-Reply-To: <1453490128.13870.31.camel@perches.com> X-Cookie: APL hackers do it in the quad. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 1/2] regulator: core: Use a bitfield for continuous_voltage_range X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --xwQtY96q3287+Drf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Jan 22, 2016 at 11:15:28AM -0800, Joe Perches wrote: > On Thu, 2016-01-21 at 20:24 +0000, Mark Brown wrote: > > - bool continuous_voltage_range; > > + unsigned int continuous_voltage_range:1; > Is this really valuable? > There are already padding bytes that are unused > and adding a couple more bools would be space > cost-free and more readable. > I believe that read/write of bytes is also more > efficient on some architectures than bit field > read/modify/write uses. It adds up when you get more flags and these are not in the least bit performance sensitive. --xwQtY96q3287+Drf Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWop+iAAoJECTWi3JdVIfQF/oH/iv+d9TCy4izXc4oGNX017ba 5XTZ7GAyHi2k8/kw5/8MCdOP/cT9+VWxhyZ0G8CXUlfvihFcC2noU/qsAgoRRhPX oeSrtmG5xwykJ82YmIlAqo63M3KubZQiiR+kisDUURdNg36eGScsUiWsh/6dcNAf zemrVRx3TDZdKLIWNhAGRd0LtYmf7rPMq+gJu8m06Wk7Ys+1HRVgnuQOnpLeLj4Q bQIWnPKn3XcgbmNu2xCg9fbs5BpQOeeWJ6eiW+ENF3uHQ+vdFQuCHC8z8bSYNNi2 VBMnfnm/FoAXLUV1VfNE8IyCwlZtaVKEP/F4qjlO71+l4uQ3mexbafIGnkXgTGU= =xmN5 -----END PGP SIGNATURE----- --xwQtY96q3287+Drf--