From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753471AbcAWPQa (ORCPT ); Sat, 23 Jan 2016 10:16:30 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:43254 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750759AbcAWPQ2 (ORCPT ); Sat, 23 Jan 2016 10:16:28 -0500 Date: Sat, 23 Jan 2016 15:16:16 +0000 From: Mark Brown To: Joe Perches Cc: Paul Kocialkowski , Liam Girdwood , linux-kernel@vger.kernel.org Message-ID: <20160123151616.GH6588@sirena.org.uk> References: <1453407851-8039-1-git-send-email-broonie@kernel.org> <1453490128.13870.31.camel@perches.com> <20160122213115.GF6588@sirena.org.uk> <1453498953.13870.41.camel@perches.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="7SdHTC2uUYj4Zouy" Content-Disposition: inline In-Reply-To: <1453498953.13870.41.camel@perches.com> X-Cookie: APL hackers do it in the quad. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 1/2] regulator: core: Use a bitfield for continuous_voltage_range X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --7SdHTC2uUYj4Zouy Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Jan 22, 2016 at 01:42:33PM -0800, Joe Perches wrote: > On Fri, 2016-01-22 at 21:31 +0000, Mark Brown wrote: > > It adds up when you get more flags and these are not in the least bit > > performance sensitive. > Sure, but intelligibility is useful too. I'm really not sure the use of small integers for boolean flags is going to be an especially troubling barrier for people. > Do you expect to have more than 4 of these flags? It's plausible. --7SdHTC2uUYj4Zouy Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWo5lAAAoJECTWi3JdVIfQRJoH/2NvCsn8co95npyUzils0wsV ePcRYjNm/vAoAkw1YLK0rujgtbqx3qKEC3TLeSo890HN3cmrJNiqm/NKi51Q66X9 0+FRu0N9o6kWIFgVzYLLilW5Pu73LxvtzUxR8bwNjw4OxdD/iVgFiATEMgvx9Ti0 vU8pkZ0S0swmaIcPlhCq0ZYNxuweMU4r5RwT7e2Ml/1znqamkNCEf6iccu/YiCty Z6gAJdV28rhaEOhb+jYj+X0s7Zo+m/kYRGKLbCIB4ZHTTchBCGr6nWwmMWvTXF79 oMR7UCISu3ASjGkz3jVSfN482sKSstC7WSxw6v0TlnMaE71SfdGtX4f0oCOC/oc= =3AsM -----END PGP SIGNATURE----- --7SdHTC2uUYj4Zouy--