From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754297AbcAXQ4g (ORCPT ); Sun, 24 Jan 2016 11:56:36 -0500 Received: from down.free-electrons.com ([37.187.137.238]:40539 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751644AbcAXQ4c (ORCPT ); Sun, 24 Jan 2016 11:56:32 -0500 Date: Sun, 24 Jan 2016 17:56:31 +0100 From: Maxime Ripard To: Chen-Yu Tsai Cc: Ulf Hansson , Hans de Goede , "linux-mmc@vger.kernel.org" , linux-arm-kernel , linux-kernel , linux-sunxi Subject: Re: [PATCH RFC 09/15] ARM: dts: sun6i: sina31s: Switch to mmc3 for onboard eMMC Message-ID: <20160124165631.GB7908@lukather> References: <1453354002-28366-1-git-send-email-wens@csie.org> <1453354002-28366-10-git-send-email-wens@csie.org> <20160122203927.GC3682@lukather> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="f2QGlHpHGjS2mn6Y" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --f2QGlHpHGjS2mn6Y Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Sat, Jan 23, 2016 at 12:21:55PM +0800, Chen-Yu Tsai wrote: > On Sat, Jan 23, 2016 at 4:39 AM, Maxime Ripard > wrote: > > Hi, > > > > On Thu, Jan 21, 2016 at 01:26:36PM +0800, Chen-Yu Tsai wrote: > >> According to Allwinner, only mmc3 supports 8 bit DDR transfers for eMM= C. > >> Switch to mmc3 for the onboard eMMC, and also assign vqmmc for signal > >> voltage sensing/switching, and "cap-mmc-hw-reset" to denote this > >> instance can use eMMC hardware reset. > >> > >> Signed-off-by: Chen-Yu Tsai > >> --- > >> arch/arm/boot/dts/sun6i-a31s-sina31s-core.dtsi | 6 ++++-- > >> 1 file changed, 4 insertions(+), 2 deletions(-) > >> > >> diff --git a/arch/arm/boot/dts/sun6i-a31s-sina31s-core.dtsi b/arch/arm= /boot/dts/sun6i-a31s-sina31s-core.dtsi > >> index ea69fb8ad4d8..4ec0c8679b2e 100644 > >> --- a/arch/arm/boot/dts/sun6i-a31s-sina31s-core.dtsi > >> +++ b/arch/arm/boot/dts/sun6i-a31s-sina31s-core.dtsi > >> @@ -61,12 +61,14 @@ > >> }; > >> > >> /* eMMC on core board */ > >> -&mmc2 { > >> +&mmc3 { > >> pinctrl-names =3D "default"; > >> - pinctrl-0 =3D <&mmc2_8bit_emmc_pins>; > >> + pinctrl-0 =3D <&mmc3_8bit_emmc_pins>; > >> vmmc-supply =3D <®_dcdc1>; > >> + vqmmc-supply =3D <®_dcdc1>; > > > > That seems odd. IIRC the VCC was supposed to be fixed and VCCQ could > > be either at 1.8 or 3V. Having the same regulator on both would make > > VCCQ forced to 3.3V, which seems to go against your commit log. > > > > What's the catch ? :) >=20 > That is how the board is routed. Which means the only use for > vqmmc-supply is the driver will know that it can only do 3.3V, > i.e. voltage sensing. >=20 > It is the reason I requested Olimex to look into this. Allwinner > reference designs all tie vqmmc directly to 3.3V. >=20 > Actually with the latest driver patches, this is not even needed. To > make the driver backward compatible, if no vqmmc-supply is given, it > just assumes 3.3V signaling. Ok. I've applied this patch and changed the commit log to remove the voltage switching mention then, since it won't happen. Thanks! Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --f2QGlHpHGjS2mn6Y Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWpQI+AAoJEBx+YmzsjxAgNIkQALn4ehGVwd8r7mYQO8mnPcS+ aOk58a8LVbQo7H7nYEPEnKQnGD4xNnpVdi/2gcwLVZmMJ+XOLs4dNag1S40DzbDP zgouH0xIvRSUZlrbutJv5AQXgjQpJunIyBou+yYh4SFChDmZmlPLuTEJVSIkPgeS oO8kOp3VWttbqfx5cVlTRJ9jOQaJFlYF4Pt+m5ol3zedQEjYJE5sDrsl+MnXWvNE +/oW++qfBLP14O0iBFbw54irEJRgC2RwPI9g+j0fNXHlor2yBdPjXVAcQuIyt1P/ QciHgkaGP75ZVSRMFPXWPIzg0SAH/9Ssg42PyVCUIFO6L674YCsG+20TuXo7+PvM fEtBeTY5U0QZOZaCc27EwKF8BGRqs0e4QwKJEJH3hrNMLb6snMKWnN1JYI/tS5cu KxL2F29XjPS8dS+b60ywfa/cKWkasf/v5OjnN7KOH1pG2pCzbktiDiM0aRg0e6fK 2le2bwymN73B9CBB1Znvc9Oirg9jJkZVoXd+NloTXXfahj5aLXnTnWQJHWj0NgVU Q9h7CHDYrsniSQDKriaQ6PDdI8MlqS/Bu9ptn32BKbCTHc7Kbg1UVK6bBbyIeZ/O 6diT0avfIvsVP5KfQ0ciaDqgvErLuY1qrv8K0DWDYzgT4e3/IsHF6100LZU1rBtY SgF/Qkms7HoOZU0hk2zO =oO41 -----END PGP SIGNATURE----- --f2QGlHpHGjS2mn6Y--