linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Darren Hart <dvhart@infradead.org>
To: Josh Boyer <jwboyer@fedoraproject.org>
Cc: Ike Panhc <ike.pan@canonical.com>,
	platform-driver-x86@vger.kernel.org,
	"Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>,
	"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH] ideapad-laptop: Add Lenovo Yoga 700 to no_hw_rfkill dmi list
Date: Sun, 24 Jan 2016 10:12:06 -0800	[thread overview]
Message-ID: <20160124181206.GJ1979@malice.jf.intel.com> (raw)
In-Reply-To: <CA+5PVA65=TRXf25_j95JWeeJjMivfcrp=6=7Yej35hstyAbiTw@mail.gmail.com>

On Sat, Jan 23, 2016 at 07:57:23AM -0500, Josh Boyer wrote:
> On Sat, Jan 23, 2016 at 2:27 AM, Darren Hart <dvhart@infradead.org> wrote:
> > On Mon, Jan 18, 2016 at 02:32:53PM -0500, Josh Boyer wrote:
> >> Like the Yoga 900 models the Lenovo Yoga 700 does not have a
> >> hw rfkill switch, and trying to read the hw rfkill switch through the
> >> ideapad module causes it to always reported blocking breaking wifi.
> >>
> >> This commit adds the Lenovo Yoga 700 to the no_hw_rfkill dmi list, fixing
> >> the wifi breakage.
> >>
> >> BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1295272
> >> Tested-by: <dinyar.rabady+spam@gmail.com>
> >> Cc: stable@vger.kernel.org
> >> Signed-off-by: Josh Boyer <jwboyer@fedoraproject.org>
> >> ---
> >>
> >> This applies to the for-next branch of the platform-x86-drivers tree
> >>
> >>
> >>  drivers/platform/x86/ideapad-laptop.c | 7 +++++++
> >>  1 file changed, 7 insertions(+)
> >>
> >> diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c
> >> index d28db0e793df..51178626305d 100644
> >> --- a/drivers/platform/x86/ideapad-laptop.c
> >> +++ b/drivers/platform/x86/ideapad-laptop.c
> >> @@ -900,6 +900,13 @@ static const struct dmi_system_id no_hw_rfkill_list[] = {
> >>               },
> >>       },
> >>       {
> >> +             .ident = "Lenogo Yoga 700",
> >
> > Josh,
> >
> > Is this a typo? "Lenogo"? Please tell me it's a typo.... :-)
> 
> Ugh, yes.  A typo.  One that apparently doesn't matter in
> functionality because the tester used this exact patch and things
> work, but embarrassing either way.
> 
> Do you need me to send a v2, or is that something you can fixup?

Normally I could have just fixed it up. I had some emergency travel on Friday
until now, so couldn't get back to it. Thank you for resending.

-- 
Darren Hart
Intel Open Source Technology Center

  reply	other threads:[~2016-01-24 18:12 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-18 19:32 [PATCH] ideapad-laptop: Add Lenovo Yoga 700 to no_hw_rfkill dmi list Josh Boyer
2016-01-20 14:18 ` Josh Boyer
2016-01-20 16:47   ` Darren Hart
2016-01-20 16:49     ` Josh Boyer
2016-01-21 21:52 ` Darren Hart
2016-01-23  7:27 ` Darren Hart
2016-01-23 12:57   ` Josh Boyer
2016-01-24 18:12     ` Darren Hart [this message]
2016-01-24 15:46 ` [PATCH v2] " Josh Boyer
2016-01-24 18:16   ` Darren Hart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160124181206.GJ1979@malice.jf.intel.com \
    --to=dvhart@infradead.org \
    --cc=ike.pan@canonical.com \
    --cc=jwboyer@fedoraproject.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).