From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932546AbcAYOZb (ORCPT ); Mon, 25 Jan 2016 09:25:31 -0500 Received: from mail-pf0-f169.google.com ([209.85.192.169]:36533 "EHLO mail-pf0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932279AbcAYOZ0 (ORCPT ); Mon, 25 Jan 2016 09:25:26 -0500 Date: Mon, 25 Jan 2016 23:24:24 +0900 From: Namhyung Kim To: Jiri Olsa Cc: Jiri Olsa , Arnaldo Carvalho de Melo , lkml , David Ahern , Ingo Molnar , Peter Zijlstra Subject: Re: [RFC 00/26] perf tools: Introduce hists specific format entries Message-ID: <20160125142424.GA7794@danjae.kornet> References: <1453109064-1026-1-git-send-email-jolsa@kernel.org> <20160125071552.GB23869@krava.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20160125071552.GB23869@krava.brq.redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jiri, On Mon, Jan 25, 2016 at 08:15:52AM +0100, Jiri Olsa wrote: > On Mon, Jan 18, 2016 at 10:23:58AM +0100, Jiri Olsa wrote: > > hi, > > currently we have global format sort and output > > lists. This rfc patchset introduces hists object > > based format entries to allow the hist object to > > carry specific format entries. > > > > This will allow to have distinguished hist objects > > displaying different stuff in output. The concepth is OK. But I don't want to embed hists into the hist_entry for hierarchy mode. As you said it'd be better to factor out common bits and embed it both from hists and hist entry. In the minimal, two rbroot (for in and out) and a format list would be required IMHO. Thanks, Namhyung