From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932822AbcAYPFJ (ORCPT ); Mon, 25 Jan 2016 10:05:09 -0500 Received: from mx1.redhat.com ([209.132.183.28]:53715 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932102AbcAYPFG (ORCPT ); Mon, 25 Jan 2016 10:05:06 -0500 Date: Mon, 25 Jan 2016 09:05:04 -0600 From: Josh Poimboeuf To: Chris J Arges Cc: live-patching@vger.kernel.org, x86@kernel.org, pbonzini@redhat.com, gleb@kernel.org, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] x86/kvm: Add output operand in vmx_handle_external_intr inline asm Message-ID: <20160125150504.GC19233@treble.redhat.com> References: <20160122204744.GI20502@treble.redhat.com> <1453499078-9330-1-git-send-email-chris.j.arges@canonical.com> <1453499078-9330-3-git-send-email-chris.j.arges@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1453499078-9330-3-git-send-email-chris.j.arges@canonical.com> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 22, 2016 at 03:44:38PM -0600, Chris J Arges wrote: > Stacktool generates the following warning: > stacktool: arch/x86/kvm/vmx.o: vmx_handle_external_intr()+0x67: call without frame pointer save/setup > > By adding the stackpointer as an output operand, this patch ensures that a > stack frame is created when CONFIG_FRAME_POINTER is enabled for the inline > assmebly statement. > > Signed-off-by: Chris J Arges Reviewed-by: Josh Poimboeuf > --- > arch/x86/kvm/vmx.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c > index e2951b6..e153522 100644 > --- a/arch/x86/kvm/vmx.c > +++ b/arch/x86/kvm/vmx.c > @@ -8356,6 +8356,7 @@ static void vmx_complete_atomic_exit(struct vcpu_vmx *vmx) > static void vmx_handle_external_intr(struct kvm_vcpu *vcpu) > { > u32 exit_intr_info = vmcs_read32(VM_EXIT_INTR_INFO); > + register void *__sp asm(_ASM_SP); > > /* > * If external interrupt exists, IF bit is set in rflags/eflags on the > @@ -8388,8 +8389,9 @@ static void vmx_handle_external_intr(struct kvm_vcpu *vcpu) > "call *%[entry]\n\t" > : > #ifdef CONFIG_X86_64 > - [sp]"=&r"(tmp) > + [sp]"=&r"(tmp), > #endif > + "+r"(__sp) > : > [entry]"r"(entry), > [ss]"i"(__KERNEL_DS), > -- > 2.5.0 >