From: Jiri Olsa <jolsa@redhat.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Jiri Olsa <jolsa@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
Andi Kleen <andi@firstfloor.org>, David Ahern <dsahern@gmail.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Wang Nan <wangnan0@huawei.com>
Subject: Re: [PATCHSET 00/10] perf tools: Apply percent-limit to callchains (v2)
Date: Thu, 28 Jan 2016 09:16:11 +0100 [thread overview]
Message-ID: <20160128081611.GC2322@krava.brq.redhat.com> (raw)
In-Reply-To: <1453909257-26015-1-git-send-email-namhyung@kernel.org>
On Thu, Jan 28, 2016 at 12:40:47AM +0900, Namhyung Kim wrote:
> Hello,
>
> This patchset tries to implement percent limit to callchains which was
> requested by Andi Kleen. For some reason, limiting callchains by
> (overhead) percentage didn't work well. This patch fixes it and make
> --percent-limit also works for callchains as well as hist entries.
>
> * Changes from v1)
> - fix insertion path instead of changing all UI code
> - show percent value even on single path (if needed)
> - change default callchain percent limit
>
> This is available on 'perf/callchain-limit-v2' branch in my tree:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git
>
> Any comments are welcome,
>
> Thanks,
> Namhyung
> *** BLURB HERE ***
>
> Namhyung Kim (10):
> perf hists: Fix min callchain hits calculation
> perf hists: Update hists' total period when adding entries
> perf report: Apply --percent-limit to callchains also
> perf report: Get rid of hist_entry__callchain_fprintf()
> perf tools: Pass parent_samples to __callchain__fprintf_graph()
> perf report: Fix percent display in callchains on --stdio
> perf hists browser: Fix dump to show correct callchain style
> perf hists browser: Pass parent_total to callchain print functions
> perf hists browser: Fix percent display in callchains
> perf tools: Change default calchain percent limit to 0.005%
also I see extra fo entries with callchain filtered out in stdio mode
jirka
---
8.41% yes libc-2.21.so [.] fputs_unlocked
|
---fputs_unlocked
|
|--5.67%--0x757074756f206472
|
--2.74%--0x3ba8e0
0x21e000
2.47% yes yes [.] fputs_unlocked@plt
|
---fputs_unlocked@plt
0x3ba8e0
0x21e000
0.12% yes [kernel.vmlinux] [k] vfs_write
0.09% yes libc-2.21.so [.] _IO_do_write@@GLIBC_2.2.5
0.08% yes [kernel.vmlinux] [k] entry_SYSCALL_64
0.07% yes [kernel.vmlinux] [k] fsnotify
0.06% yes [kernel.vmlinux] [k] sys_write
next prev parent reply other threads:[~2016-01-28 8:16 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-27 15:40 [PATCHSET 00/10] perf tools: Apply percent-limit to callchains (v2) Namhyung Kim
2016-01-27 15:40 ` [PATCH 01/10] perf hists: Fix min callchain hits calculation Namhyung Kim
2016-02-03 10:21 ` [tip:perf/core] " tip-bot for Namhyung Kim
2016-01-27 15:40 ` [PATCH 02/10] perf hists: Update hists' total period when adding entries Namhyung Kim
2016-02-03 10:21 ` [tip:perf/core] " tip-bot for Namhyung Kim
2016-01-27 15:40 ` [PATCH 03/10] perf report: Apply --percent-limit to callchains also Namhyung Kim
2016-02-01 20:19 ` Arnaldo Carvalho de Melo
2016-02-02 13:05 ` Namhyung Kim
2016-02-02 13:55 ` Arnaldo Carvalho de Melo
2016-02-02 14:15 ` Namhyung Kim
2016-02-02 14:27 ` Arnaldo Carvalho de Melo
2016-02-02 14:35 ` Namhyung Kim
2016-02-02 14:57 ` Arnaldo Carvalho de Melo
2016-02-02 15:03 ` Namhyung Kim
2016-02-03 10:22 ` [tip:perf/core] " tip-bot for Namhyung Kim
2016-01-27 15:40 ` [PATCH 04/10] perf report: Get rid of hist_entry__callchain_fprintf() Namhyung Kim
2016-02-03 10:22 ` [tip:perf/core] " tip-bot for Namhyung Kim
2016-01-27 15:40 ` [PATCH 05/10] perf tools: Pass parent_samples to __callchain__fprintf_graph() Namhyung Kim
2016-02-03 10:22 ` [tip:perf/core] perf callchain: " tip-bot for Namhyung Kim
2016-01-27 15:40 ` [PATCH 06/10] perf report: Fix percent display in callchains on --stdio Namhyung Kim
2016-02-03 10:22 ` [tip:perf/core] " tip-bot for Namhyung Kim
2016-01-27 15:40 ` [PATCH 07/10] perf hists browser: Fix dump to show correct callchain style Namhyung Kim
2016-02-03 10:23 ` [tip:perf/core] " tip-bot for Namhyung Kim
2016-01-27 15:40 ` [PATCH 08/10] perf hists browser: Pass parent_total to callchain print functions Namhyung Kim
2016-02-03 10:23 ` [tip:perf/core] " tip-bot for Namhyung Kim
2016-01-27 15:40 ` [PATCH 09/10] perf hists browser: Fix percent display in callchains Namhyung Kim
2016-02-03 10:24 ` [tip:perf/core] " tip-bot for Namhyung Kim
2016-01-27 15:40 ` [RFC/PATCH 10/10] perf tools: Change default calchain percent limit to 0.005% Namhyung Kim
2016-01-27 16:06 ` Andi Kleen
2016-01-27 23:34 ` Namhyung Kim
2016-01-28 8:14 ` [PATCHSET 00/10] perf tools: Apply percent-limit to callchains (v2) Jiri Olsa
2016-01-28 8:42 ` Namhyung Kim
2016-01-28 8:16 ` Jiri Olsa [this message]
2016-01-28 10:14 ` Namhyung Kim
2016-01-28 10:16 ` Namhyung Kim
2016-01-28 12:12 ` Jiri Olsa
2016-01-28 12:24 ` Namhyung Kim
2016-01-28 19:52 ` Jiri Olsa
2016-01-29 21:00 ` Arnaldo Carvalho de Melo
2016-01-30 13:52 ` Namhyung Kim
2016-02-03 10:24 ` [tip:perf/core] perf report: Don' t show blank lines if entry has no callchain tip-bot for Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160128081611.GC2322@krava.brq.redhat.com \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=andi@firstfloor.org \
--cc=dsahern@gmail.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).