From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933011AbcA2SBE (ORCPT ); Fri, 29 Jan 2016 13:01:04 -0500 Received: from arroyo.ext.ti.com ([192.94.94.40]:55418 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932801AbcA2SBA (ORCPT ); Fri, 29 Jan 2016 13:01:00 -0500 Date: Fri, 29 Jan 2016 12:00:07 -0600 From: Andreas Dannenberg To: Alexander Koch CC: , , , , , , , , Subject: Re: [PATCH v2 2/3] iio: light: opt3001: trivial type refactoring Message-ID: <20160129180007.GB7960@LTA0797059A> References: <1452960878-1727-1-git-send-email-mail@alexanderkoch.net> <1452960878-1727-3-git-send-email-mail@alexanderkoch.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1452960878-1727-3-git-send-email-mail@alexanderkoch.net> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jan 16, 2016 at 05:14:37PM +0100, Alexander Koch wrote: > Change variable type of struct opt3001 members 'ok_to_ignore_lock' and > 'result_ready' uint16-bitfield of length one to bool. > > They are used as bool, let the compiler do the optimization. > > Signed-off-by: Alexander Koch > Signed-off-by: Michael Hornung Tested-by: Andreas Dannenberg > --- > drivers/iio/light/opt3001.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/iio/light/opt3001.c b/drivers/iio/light/opt3001.c > index aefbd79..b05c484 100644 > --- a/drivers/iio/light/opt3001.c > +++ b/drivers/iio/light/opt3001.c > @@ -79,8 +79,8 @@ struct opt3001 { > struct device *dev; > > struct mutex lock; > - u16 ok_to_ignore_lock:1; > - u16 result_ready:1; > + bool ok_to_ignore_lock; > + bool result_ready; > wait_queue_head_t result_ready_queue; > u16 result; > > -- > 2.7.0 >