From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756801AbcA3AeO (ORCPT ); Fri, 29 Jan 2016 19:34:14 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:36461 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756625AbcA3AeK (ORCPT ); Fri, 29 Jan 2016 19:34:10 -0500 Date: Fri, 29 Jan 2016 16:34:09 -0800 From: Stephen Boyd To: Andi Shyti Cc: linux-samsung-soc@vger.kernel.org, Sangbeom Kim , Krzysztof Kozlowski , Michael Turquette , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, Andi Shyti , Yadwinder Singh Brar , Jaehoon Chung Subject: Re: [PATCH v3 3/4] clk: s2mps11: remove redundant static variables declaration Message-ID: <20160130003409.GJ12841@codeaurora.org> References: <1453284864-8082-1-git-send-email-andi.shyti@samsung.com> <1453284864-8082-4-git-send-email-andi.shyti@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1453284864-8082-4-git-send-email-andi.shyti@samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/20, Andi Shyti wrote: > The clk_table and clk_data are declared static. The clk_table > contains the three clock data stractures belonging to the s2mps11 > driver. In the probe function it gets stored into clk_data. > > Remove clk_table and refer directly to clk_data. > > clk_data, itself, is also declared static. Declare locally it > and allocate it inside the probe function, as it is not used > anywhere else. > > Signed-off-by: Andi Shyti > --- Applied to clk-next -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project