From: Jean Delvare <jdelvare@suse.de>
To: Andy Lutomirski <luto@amacapital.net>
Cc: "Darren Hart" <dvhart@infradead.org>,
"Andy Lutomirski" <luto@kernel.org>,
"Pali Rohár" <pali.rohar@gmail.com>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] dmi: Make dmi_walk and dmi_walk_early return real error codes
Date: Sat, 30 Jan 2016 20:18:50 +0100 [thread overview]
Message-ID: <20160130201850.3fd167e9@endymion.delvare> (raw)
In-Reply-To: <CALCETrXbvv2nQ6XJSocbEukoFQbWd437jaRQ4WjGigxjrMNtGw@mail.gmail.com>
On Sat, 30 Jan 2016 10:13:09 -0800, Andy Lutomirski wrote:
> On Sat, Jan 30, 2016 at 10:05 AM, Darren Hart <dvhart@infradead.org> wrote:
> > If I understand this correctly, this is the first of 5 patches, and this one has
> > some unanswered questions from Jean here. If this patch gets respun, the
> > following are also impacted:
> >
> > dell-wmi: Stop storing pointers to DMI tables
> > dell-wmi, dell-laptop: select DMI
> > dell-wmi: Clean up hotkey table size check
> > dell-wmi: Support new hotkeys on the XPS 13 9350 (Skylake)
> >
> > Is that correct?
>
> Not really. It's just the three patches here:
>
> http://article.gmane.org/gmane.linux.drivers.platform.x86.devel/8503
>
> This patch (the dmi_walk error code one) is no longer really related.
> Due to Jean's earlier comment about what happens if DMI isn't enabled
> at all, I no longer propagate the error code from dmi_walk in
> dell-wmi, so the error code won't have any effect. (Instead I just
> warn and let the driver load in legacy mode, which matches the current
> behavior.)
>
> I think the way to go is for the v3 "dell-wmi: DMI misuse fixes"
> series to go in through your tree, and I'll hash out the error code
> thing separately with Jean.
>
> Does that seem sensible?
Yes, I agree that this patch is independent from the dell-wmi patch
series now.
--
Jean Delvare
SUSE L3 Support
next prev parent reply other threads:[~2016-01-30 19:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-19 23:54 [PATCH v3] dmi: Make dmi_walk and dmi_walk_early return real error codes Andy Lutomirski
2016-01-22 9:12 ` Jean Delvare
2016-01-30 18:05 ` Darren Hart
2016-01-30 18:13 ` Andy Lutomirski
2016-01-30 19:18 ` Jean Delvare [this message]
2016-02-02 17:00 ` Darren Hart
2016-02-12 18:59 ` Andy Lutomirski
2016-02-13 0:12 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160130201850.3fd167e9@endymion.delvare \
--to=jdelvare@suse.de \
--cc=dvhart@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=luto@kernel.org \
--cc=pali.rohar@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).