From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757187AbcA3Xcb (ORCPT ); Sat, 30 Jan 2016 18:32:31 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59133 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757155AbcA3Xca (ORCPT ); Sat, 30 Jan 2016 18:32:30 -0500 From: "Benjamin Marzinski" Date: Sat, 30 Jan 2016 17:32:28 -0600 To: Hannes Reinecke Cc: "dm-devel@redhat.com" , "corbet@lwn.net" , "linux-kernel@vger.kernel.org" , Mike Snitzer , "Nalla, Ravikanth" Subject: Re: [dm-devel] [PATCH v2] dm pref-path: provides preferred path load balance policy Message-ID: <20160130233228.GF24960@octiron.msp.redhat.com> References: <1453469502-15606-1-git-send-email-ravikanth.nalla@hpe.com> <56A231C8.90602@suse.de> <20160122165932.GA28761@redhat.com> <49D617FA63152941907AADE32CF072F12FD72905@G4W3202.americas.hpqcorp.net> <20160129175059.GB24960@octiron.msp.redhat.com> <56AC7535.2090401@suse.de> <20160130202525.GE24960@octiron.msp.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160130202525.GE24960@octiron.msp.redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jan 30, 2016 at 02:25:25PM -0600, Benjamin Marzinski wrote: > Before this commit, it always used the pref bit. Again, like I said > before, I'm saying that this was the wrong thing to do. The Spec is Oops. I meant: "I'm NOT saying that this was the wrong thing to do". I am also fine with changing the default back to making the pref bit always create it's own path group. As long there is a way for users to get either behavior, I'm happy. -Ben > pretty vague on what you should expect to happen when you set to pref > bit. When the path was in a group by itself, I got complaints. Now that > the path is is a group with other active/optimized paths, I get > complaints. The only answer is to allow the user to say what they want > the pref bit to mean. > > -Ben