From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752626AbcBAIVj (ORCPT ); Mon, 1 Feb 2016 03:21:39 -0500 Received: from helcar.hengli.com.au ([209.40.204.226]:42333 "EHLO helcar.hengli.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751647AbcBAIVh (ORCPT ); Mon, 1 Feb 2016 03:21:37 -0500 Date: Mon, 1 Feb 2016 16:21:30 +0800 From: Herbert Xu To: Rui Wang Cc: tim.c.chen@linux.intel.com, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 4/4] crypto: testmgr - Add a test case for import()/export() Message-ID: <20160201082130.GD5818@gondor.apana.org.au> References: <1453885718-24599-1-git-send-email-rui.y.wang@intel.com> <1453885718-24599-5-git-send-email-rui.y.wang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1453885718-24599-5-git-send-email-rui.y.wang@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 27, 2016 at 05:08:38PM +0800, Rui Wang wrote: > > diff --git a/crypto/testmgr.h b/crypto/testmgr.h > index da0a8fd..451e7eb 100644 > --- a/crypto/testmgr.h > +++ b/crypto/testmgr.h > @@ -44,6 +44,7 @@ struct hash_testvec { > unsigned short psize; > unsigned char np; > unsigned char ksize; > + unsigned char partial; Why not make it unconditional? Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt