From: Brian Norris <computersforpeace@gmail.com>
To: Richard Weinberger <richard@nod.at>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
uml-devel <user-mode-linux-devel@lists.sourceforge.net>,
David Woodhouse <dwmw2@infradead.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Bill Pringlemeir <bpringlemeir@nbsps.com>,
Stefan Agner <stefan@agner.ch>,
Alex Smith <alex.smith@imgtec.com>,
Zhou Wang <wangzhou1@hisilicon.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Anup Patel <anup.patel@broadcom.com>,
MTD Maling List <linux-mtd@lists.infradead.org>
Subject: Re: [PATCH 21/22] mtd: cs553x: Fix dependencies for !HAS_IOMEM archs
Date: Mon, 1 Feb 2016 09:38:27 -0800 [thread overview]
Message-ID: <20160201173827.GE19540@google.com> (raw)
In-Reply-To: <56A77B7B.2000305@nod.at>
On Tue, Jan 26, 2016 at 02:58:19PM +0100, Richard Weinberger wrote:
> Am 26.01.2016 um 12:00 schrieb Geert Uytterhoeven:
> > On Mon, Jan 25, 2016 at 11:24 PM, Richard Weinberger <richard@nod.at> wrote:
> >> Not every arch has io memory nor can this driver ever work
> >> on UML/i386.
> >> So, unbreak the build by fixing the dependencies.
> >>
> >> Signed-off-by: Richard Weinberger <richard@nod.at>
> >> ---
> >> drivers/mtd/nand/Kconfig | 1 +
> >> 1 file changed, 1 insertion(+)
> >>
> >> diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
> >> index 545d82b..b253654 100644
> >> --- a/drivers/mtd/nand/Kconfig
> >> +++ b/drivers/mtd/nand/Kconfig
> >> @@ -311,6 +311,7 @@ config MTD_NAND_CAFE
> >> config MTD_NAND_CS553X
> >> tristate "NAND support for CS5535/CS5536 (AMD Geode companion chip)"
> >> depends on X86_32
> >> + depends on !UML && HAS_IOMEM
> >
> > I don't think there's a need for the !UML dependency?
> > Hence just "depends on X86_32 && HAS_IOMEM"?
>
> Strictly speaking this would work as HAS_IOMEM implies !UML.
> The build error shows that it fails also because UML/i386 is x86_32
> but lacks some x86_32 stuff:
>
[...]
>
> Maybe a "depends on X86_32 && !UML" would make more sense. hmm?
That may be slightly clearer, but it's equivalent, so I've applied this
patch as-is.
Thanks,
Brian
next prev parent reply other threads:[~2016-02-01 17:38 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-25 22:23 Richard Weinberger
2016-01-25 22:24 ` [PATCH 01/22] power: reset: Fix dependencies for !HAS_IOMEM archs Richard Weinberger
2016-01-26 23:34 ` Florian Fainelli
2016-01-27 8:02 ` Richard Weinberger
2016-02-15 5:57 ` Sebastian Reichel
2016-01-25 22:24 ` [PATCH 02/22] phy: " Richard Weinberger
2016-02-03 6:21 ` Kishon Vijay Abraham I
2016-01-25 22:24 ` [PATCH 03/22] scsi: Fix dependencies for !HAS_IOMEM and !HAS_DMA archs Richard Weinberger
2016-01-26 10:15 ` John Garry
2016-01-26 10:31 ` Richard Weinberger
2016-01-26 10:54 ` John Garry
2016-01-27 2:16 ` Martin K. Petersen
2016-01-25 22:24 ` [PATCH 04/22] staging: iio: Fix dependencies for !HAS_IOMEM archs Richard Weinberger
2016-01-26 10:59 ` Geert Uytterhoeven
2016-01-30 15:47 ` Jonathan Cameron
2016-01-25 22:24 ` [PATCH 05/22] hw_random: " Richard Weinberger
2016-01-26 9:58 ` Daniel Thompson
2016-01-26 14:49 ` Herbert Xu
2016-01-25 22:24 ` [PATCH 06/22] iio: adc: " Richard Weinberger
2016-01-30 15:44 ` Jonathan Cameron
2016-01-25 22:24 ` [PATCH 07/22] fpga: " Richard Weinberger
2016-01-25 23:33 ` Moritz Fischer
2016-01-25 22:24 ` [PATCH 08/22] hwtracing: " Richard Weinberger
2016-02-05 14:07 ` Alexander Shishkin
2016-01-25 22:24 ` [PATCH 09/22] leds: " Richard Weinberger
2016-01-25 22:42 ` Richard Weinberger
2016-01-25 22:24 ` [PATCH 10/22] mailbox: " Richard Weinberger
2016-01-25 22:24 ` [PATCH 11/22] mtd: " Richard Weinberger
2016-01-26 11:00 ` Geert Uytterhoeven
2016-01-26 19:31 ` Brian Norris
2016-01-25 22:24 ` [PATCH 12/22] nvmem: " Richard Weinberger
2016-01-26 11:19 ` Srinivas Kandagatla
2016-01-26 14:20 ` Richard Weinberger
2016-01-25 22:24 ` [PATCH 13/22] net: " Richard Weinberger
2016-01-26 23:15 ` Noam Camus
2016-01-29 0:03 ` David Miller
2016-01-25 22:24 ` [PATCH 14/22] pwm: " Richard Weinberger
2016-01-25 22:40 ` Richard Weinberger
2016-01-25 22:24 ` [PATCH 15/22] watchdog: " Richard Weinberger
2016-01-26 2:47 ` Guenter Roeck
2016-01-25 22:24 ` [PATCH 16/22] iio: imu: " Richard Weinberger
2016-01-26 0:15 ` Paul Bolle
2016-01-26 8:17 ` Richard Weinberger
2016-01-30 15:49 ` Jonathan Cameron
2016-01-25 22:24 ` [PATCH 17/22] media: " Richard Weinberger
2016-02-01 13:26 ` Mauro Carvalho Chehab
2016-01-25 22:24 ` [PATCH 18/22] irqchip: " Richard Weinberger
2016-01-26 15:04 ` [tip:irq/urgent] irqchip: Fix dependencies for archs w/ o HAS_IOMEM tip-bot for Richard Weinberger
2016-01-25 22:24 ` [PATCH 19/22] thermal: Fix dependencies for !HAS_IOMEM archs Richard Weinberger
2016-01-25 22:24 ` [PATCH 20/22] clocksource: " Richard Weinberger
2016-01-26 15:40 ` [tip:timers/urgent] clocksource: Fix dependencies for archs w/ o HAS_IOMEM tip-bot for Richard Weinberger
2016-01-25 22:24 ` [PATCH 21/22] mtd: cs553x: Fix dependencies for !HAS_IOMEM archs Richard Weinberger
2016-01-26 11:00 ` Geert Uytterhoeven
2016-01-26 13:58 ` Richard Weinberger
2016-02-01 17:38 ` Brian Norris [this message]
2016-01-25 22:24 ` [PATCH 22/22] um: Export pm_power_off Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160201173827.GE19540@google.com \
--to=computersforpeace@gmail.com \
--cc=alex.smith@imgtec.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=anup.patel@broadcom.com \
--cc=bpringlemeir@nbsps.com \
--cc=dwmw2@infradead.org \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
--cc=stefan@agner.ch \
--cc=user-mode-linux-devel@lists.sourceforge.net \
--cc=wangzhou1@hisilicon.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).