From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754827AbcBBWZ0 (ORCPT ); Tue, 2 Feb 2016 17:25:26 -0500 Received: from mail.kernel.org ([198.145.29.136]:40518 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752906AbcBBWZZ (ORCPT ); Tue, 2 Feb 2016 17:25:25 -0500 Date: Tue, 2 Feb 2016 19:25:21 -0300 From: Arnaldo Carvalho de Melo To: Jiri Olsa Cc: Namhyung Kim , Jiri Olsa , lkml , David Ahern , Ingo Molnar , Peter Zijlstra Subject: Re: [RFC 00/26] perf tools: Introduce hists specific format entries Message-ID: <20160202222521.GK32488@kernel.org> References: <1453109064-1026-1-git-send-email-jolsa@kernel.org> <20160125071552.GB23869@krava.brq.redhat.com> <20160125142424.GA7794@danjae.kornet> <20160125143743.GA10064@krava.brq.redhat.com> <20160202222247.GJ32488@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160202222247.GJ32488@kernel.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Tue, Feb 02, 2016 at 07:22:47PM -0300, Arnaldo Carvalho de Melo escreveu: > Ok, so I rebased it on top of my perf/core branch, adjusting some stuff > wrt recent patchkits from Namhyung (hist_entry__callchain_fprintf() is > no more, etc), and renaming that perf_hpp_list->{list,sort_list} to > ->{fields,sorts} as Namhyung suggested and you agreed, it builds... > > But perf top isn't showing the overhead column... there were some > changes to perf report in this patchkit to move some initializations... > will check there... Double checking... [acme@jouet linux]$ git bisect bad cd85325039555bbf37d08d399ae2b1c91c70a565 is the first bad commit commit cd85325039555bbf37d08d399ae2b1c91c70a565 Author: Jiri Olsa Date: Mon Jan 18 10:24:07 2016 +0100 perf hists: Allocate output sort field Currently we use static output fields, because we have single global list of all sort/output fields. We will add hists specific sort and output lists in following patches, so we need all format entries to be dynamically allocated. Adding support to allocate output sort field. Signed-off-by: Jiri Olsa Cc: David Ahern Cc: Namhyung Kim Cc: Peter Zijlstra Link: http://lkml.kernel.org/r/1453109064-1026-10-git-send-email-jolsa@kernel.org Signed-off-by: Arnaldo Carvalho de Melo :040000 040000 f119a49ec0c9954f3117e151719c3c322c1651e4 4bb14abe5005fe29c45eecd9f6fab30fabc0fd99 M tools [acme@jouet linux]$