From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754123AbcBCLSn (ORCPT ); Wed, 3 Feb 2016 06:18:43 -0500 Received: from mail-wm0-f51.google.com ([74.125.82.51]:33451 "EHLO mail-wm0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751375AbcBCLSl (ORCPT ); Wed, 3 Feb 2016 06:18:41 -0500 Date: Wed, 3 Feb 2016 11:18:38 +0000 From: Matt Fleming To: Ingo Molnar Cc: "H . Peter Anvin" , Thomas Gleixner , linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Jones , Ard Biesheuvel Subject: Re: [PATCH 10/14] efi: Make checkpatch complain less about efi.h GUID additions Message-ID: <20160203111838.GB2597@codeblueprint.co.uk> References: <1454364428-494-1-git-send-email-matt@codeblueprint.co.uk> <1454364428-494-11-git-send-email-matt@codeblueprint.co.uk> <20160203103335.GA7310@gmail.com> <20160203104432.GA2597@codeblueprint.co.uk> <20160203105035.GB21257@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160203105035.GB21257@gmail.com> User-Agent: Mutt/1.5.24+41 (02bc14ed1569) (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 03 Feb, at 11:50:35AM, Ingo Molnar wrote: > > Hm, so the GUIDs are line-broken in the same fashion in the spec, after the third > parameter? Yep, they are. > That's a strong reason indeed - and then the changelog and title should say that: > 're-format GUID tables to follow the format of the UEFI spec'. That it also > pacifies checkpatch is a side effect. I think that's a fair change. Peter could you take a look at updating the changelog in a v2? If not, I'll do it.