From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755994AbcBCWro (ORCPT <rfc822;w@1wt.eu>);
	Wed, 3 Feb 2016 17:47:44 -0500
Received: from mail-wm0-f51.google.com ([74.125.82.51]:35405 "EHLO
	mail-wm0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755678AbcBCWrd (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 3 Feb 2016 17:47:33 -0500
Date: Wed, 3 Feb 2016 22:47:29 +0000
From: Matt Fleming <matt@codeblueprint.co.uk>
To: "Gabriel L. Somlo" <somlo@cmu.edu>
Cc: gregkh@linuxfoundation.org, robh+dt@kernel.org, pawel.moll@arm.com,
        mark.rutland@arm.com, ijc+devicetree@hellion.org.uk,
        galak@codeaurora.org, arnd@arndb.de, lersek@redhat.com,
        ralf@linux-mips.org, rmk+kernel@arm.linux.org.uk, eric@anholt.net,
        hanjun.guo@linaro.org, zajec5@gmail.com, sudeep.holla@arm.com,
        agross@codeaurora.org, linux-api@vger.kernel.org,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        qemu-devel@nongnu.org, mst@redhat.com, imammedo@redhat.com,
        peter.maydell@linaro.org, leif.lindholm@linaro.org,
        ard.biesheuvel@linaro.org, pbonzini@redhat.com, kraxel@redhat.com,
        ehabkost@redhat.com, luto@amacapital.net, stefanha@gmail.com,
        revol@free.fr, rth@twiddle.net
Subject: Re: [PATCH v8 0/4] SysFS driver for QEMU fw_cfg device
Message-ID: <20160203224729.GB15385@codeblueprint.co.uk>
References: <1453990994-17801-1-git-send-email-somlo@cmu.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1453990994-17801-1-git-send-email-somlo@cmu.edu>
User-Agent: Mutt/1.5.24+41 (02bc14ed1569) (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 28 Jan, at 09:23:10AM, Gabriel L. Somlo wrote:
> From: "Gabriel Somlo" <somlo@cmu.edu>
> 
> Allow access to QEMU firmware blobs, passed into the guest VM via
> the fw_cfg device, through SysFS entries. Blob meta-data (e.g. name,
> size, and fw_cfg key), as well as the raw binary blob data may be
> accessed.
> 
> The SysFS access location is /sys/firmware/qemu_fw_cfg/... and was
> selected based on overall similarity to the type of information
> exposed under /sys/firmware/dmi/entries/...
> 
> This functionality is primarily intended to serve as a host->guest
> configuration data transfer mechanism that is both:
> 
>         - asynchronous: the host doesn't need to wait for the guest
>                         to be ready to accept data (e.g., by starting
>                         an agent daemon)
> 
>         - out-of-band:  there is no need to commandeer a guest element
>                         normally visible and available to the guest user
>                         (e.g., kernel cmdline, mounting floppy/cdrom, etc.)
> 
> QEMU now allows arbitrary fw_cfg blobs to be added via the command line,
> so it would be nice to make them easy to retrieve from within the guest
> OS, and the niceset and easiest way I can think of is
> 
>         cat /sys/firmware/qemu-fw-cfg/.../<some-blob-name>/raw
> 
> New since v7:
> 
> 	- kbuild testbot complained about a warning on ia64, so limit
> 	  the availability of fw_cfg in Kconfig to only architectures
> 	  on which QEMU makes it available, which include:
> 
> 		(ARM || ARM64 || PPC_PMAC || SPARC || X86)

This is looking pretty good now. Does anyone have remaining
objections before this gets merged?