From: "Luck, Tony" <tony.luck@intel.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Ingo Molnar <mingo@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Andy Lutomirski <luto@amacapital.net>,
Peter Zijlstra <peterz@infradead.org>,
Steven Rostedt <rostedt@goodmis.org>,
Brian Gerst <brgerst@gmail.com>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -v2] x86: Add an archinfo dumper module
Date: Thu, 4 Feb 2016 11:07:57 -0800 [thread overview]
Message-ID: <20160204190757.GA4249@agluck-desk.sc.intel.com> (raw)
In-Reply-To: <20160204152235.GB5343@pd.tnic>
On Thu, Feb 04, 2016 at 04:22:35PM +0100, Borislav Petkov wrote:
> Here's v2 with the stuff we talked about, implemented. I've added
> 'control_regs' file too so that you can do:
>
> $ cat /sys/kernel/debug/x86/archinfo/control_regs
> CR4: [-|-|SMEP|OSXSAVE|-|-|-|-|OSXMMEXCPT|OSFXSR|-|PGE|MCE|PAE|PSE|-|-|-|-]: 0x1406f0
>
> for example. Yeah, only CR4 right now.
>
> Off the top of my head, we would need "msrs" which dumps EFER and a
> bunch of other interesting MSRs along with the names of the set bits.
It would be nce to have some helper function that makes it easier for
people to add new registers to this that just uses one string
to describe the format of a register. E.g. if we have a register
like this:
63 63 62 11 10 9 8 5 4 2 1 0
+-----+------+-----+------+-----+-----+
| VAL | rsvd | BAZ | rsvd | BAR | FOO |
+-----+------+-----+------+-----+-----+
BAZ bits mean:
00 - nope
01 - low
10 - mid
11 - high
we could describe it with:
"1fVAL|52r|2[nope,low,mid,high]BAZ|4r|3xBAR|2dFOO"
syntax is <width><fmt><name>
where width is the number of bits. Format is one of:
f - flag - print the name if the field is non-zero, else print nothing
(or "-" to match the format you used above for CR4)
r - reserved - skip this field
d - print name=%d
x - print name=0x%x
[str0,str1,...str{2^width - 1}] - print NAME=str[val]
-Tony
next prev parent reply other threads:[~2016-02-04 19:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-01 11:56 [RFC] Dump interesting arch/platform info Borislav Petkov
2016-02-01 23:29 ` Luck, Tony
2016-02-02 9:41 ` Borislav Petkov
2016-02-03 10:48 ` Ingo Molnar
2016-02-03 11:00 ` Borislav Petkov
2016-02-04 15:22 ` [PATCH -v2] x86: Add an archinfo dumper module Borislav Petkov
2016-02-04 19:07 ` Luck, Tony [this message]
2016-02-07 10:51 ` Borislav Petkov
2016-02-09 19:17 ` Luck, Tony
2016-02-09 19:46 ` Borislav Petkov
2016-02-05 19:51 ` Luck, Tony
2016-02-05 22:24 ` Luck, Tony
2016-02-08 0:01 ` H. Peter Anvin
2016-02-08 7:50 ` Boris Petkov
2016-02-09 12:23 ` Ingo Molnar
2016-02-09 14:01 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160204190757.GA4249@agluck-desk.sc.intel.com \
--to=tony.luck@intel.com \
--cc=bp@alien8.de \
--cc=brgerst@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).