From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754974AbcBIJAg (ORCPT ); Tue, 9 Feb 2016 04:00:36 -0500 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:46013 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752973AbcBIJAf (ORCPT ); Tue, 9 Feb 2016 04:00:35 -0500 Date: Tue, 9 Feb 2016 10:00:30 +0100 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Arnd Bergmann Cc: Greg Ungerer , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: ks8695: fix __initdata annotation Message-ID: <20160209090030.GS13664@pengutronix.de> References: <1454941509-2773774-1-git-send-email-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1454941509-2773774-1-git-send-email-arnd@arndb.de> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 08, 2016 at 03:24:57PM +0100, Arnd Bergmann wrote: > Clang complains about the __initdata section attribute being in the > wrong place in two files of ks8695: > > arch/arm/mach-ks8695/cpu.c:37:31: error: '__section__' attribute only applies to functions and global variables > arch/arm/mach-ks8695/board-og.c:83:31: error: '__section__' attribute only applies to functions and global variables > > This moves the attribute to the correct place. > > Signed-off-by: Arnd Bergmann > --- > arch/arm/mach-ks8695/board-og.c | 2 +- > arch/arm/mach-ks8695/cpu.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/mach-ks8695/board-og.c b/arch/arm/mach-ks8695/board-og.c > index 1f4f2f4f25bb..fa1a7c2ca2bb 100644 > --- a/arch/arm/mach-ks8695/board-og.c > +++ b/arch/arm/mach-ks8695/board-og.c > @@ -80,7 +80,7 @@ static void __init og_pci_bus_reset(void) > #define S8250_VIRT 0xf4000000 > #define S8250_SIZE 0x00100000 > > -static struct __initdata map_desc og_io_desc[] = { > +static struct map_desc __initdata og_io_desc[] = { I would have expected that +static struct map_desc og_io_desc[] __initdata = { is the correct variant? Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |