From: Ingo Molnar <mingo@kernel.org>
To: Yinghai Lu <yinghai@kernel.org>
Cc: luto@kernel.org, Linus Torvalds <torvalds@linux-foundation.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Alexander Kuleshov <kuleshovmail@gmail.com>,
ryabinin.a.a@gmail.com, Peter Zijlstra <peterz@infradead.org>,
alpopov@ptsecurity.com,
"linux-tip-commits@vger.kernel.org"
<linux-tip-commits@vger.kernel.org>
Subject: Re: [tip:x86/boot] x86/boot: Micro-optimize reset_early_page_tables()
Date: Tue, 9 Feb 2016 13:28:09 +0100 [thread overview]
Message-ID: <20160209122809.GA5186@gmail.com> (raw)
In-Reply-To: <CAE9FiQVJfous4xPr8UFOHQOCb0-P+YPdb3X4HtzVEysVPTA5sg@mail.gmail.com>
* Yinghai Lu <yinghai@kernel.org> wrote:
> On Sat, Jan 30, 2016 at 12:26 AM, tip-bot for Alexander Kuleshov
> <tipbot@zytor.com> wrote:
> > ---
> > arch/x86/kernel/head64.c | 14 +++-----------
> > 1 file changed, 3 insertions(+), 11 deletions(-)
> >
> > diff --git a/arch/x86/kernel/head64.c b/arch/x86/kernel/head64.c
> > index f129a9a..35843ca 100644
> > --- a/arch/x86/kernel/head64.c
> > +++ b/arch/x86/kernel/head64.c
> > @@ -40,13 +40,8 @@ pmdval_t early_pmd_flags = __PAGE_KERNEL_LARGE & ~(_PAGE_GLOBAL | _PAGE_NX);
>
> .
> >
> > @@ -54,7 +49,6 @@ static void __init reset_early_page_tables(void)
> > int __init early_make_pgtable(unsigned long address)
> > {
> > unsigned long physaddr = address - __PAGE_OFFSET;
> > - unsigned long i;
> > pgdval_t pgd, *pgd_p;
> > pudval_t pud, *pud_p;
> > pmdval_t pmd, *pmd_p;
> > @@ -81,8 +75,7 @@ again:
> > }
> >
> > pud_p = (pudval_t *)early_dynamic_pgts[next_early_pgt++];
> > - for (i = 0; i < PTRS_PER_PUD; i++)
> > - pud_p[i] = 0;
> > + memset(pud_p, 0, sizeof(pud_p) * PTRS_PER_PUD);
>
> should be
> memset(pud_p, 0, sizeof(*pud_p) * PTRS_PER_PUD);
>
> > *pgd_p = (pgdval_t)pud_p - __START_KERNEL_map + phys_base + _KERNPG_TABLE;
> > }
> > pud_p += pud_index(address);
> > @@ -97,8 +90,7 @@ again:
> > }
> >
> > pmd_p = (pmdval_t *)early_dynamic_pgts[next_early_pgt++];
> > - for (i = 0; i < PTRS_PER_PMD; i++)
> > - pmd_p[i] = 0;
> > + memset(pmd_p, 0, sizeof(pmd_p) * PTRS_PER_PMD);
>
> should be
> memset(pmd_p, 0, sizeof(*pmd_p) * PTRS_PER_PMD);
Indeed. Fortunately the two sizes are the same AFAICS, but this should
nevertheless be fixed.
Thanks,
Ingo
next prev parent reply other threads:[~2016-02-09 12:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-30 8:01 [PATCH] x86/head64: micro optimization: use memset instead of for loop Alexander Kuleshov
2016-01-30 8:26 ` [tip:x86/boot] x86/boot: Micro-optimize reset_early_page_tables() tip-bot for Alexander Kuleshov
2016-02-05 0:25 ` Yinghai Lu
2016-02-09 12:28 ` Ingo Molnar [this message]
2016-02-09 13:11 ` [PATCH v2] x86/head64: micro optimization: use memset instead of for loop Alexander Kuleshov
2016-02-09 13:18 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160209122809.GA5186@gmail.com \
--to=mingo@kernel.org \
--cc=alpopov@ptsecurity.com \
--cc=hpa@zytor.com \
--cc=kuleshovmail@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=luto@kernel.org \
--cc=peterz@infradead.org \
--cc=ryabinin.a.a@gmail.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).