From: Ingo Molnar <mingo@kernel.org>
To: Vince Weaver <vincent.weaver@maine.edu>
Cc: jolsa@redhat.com, linux-kernel@vger.kernel.org, bp@suse.de,
a.p.zijlstra@chello.nl, acme@redhat.com,
torvalds@linux-foundation.org, eranian@google.com,
peterz@infradead.org, hpa@zytor.com, tglx@linutronix.de,
linux-tip-commits@vger.kernel.org
Subject: Re: [tip:perf/core] perf/x86: Move perf_event.c ............... => x86/events/core.c
Date: Tue, 9 Feb 2016 15:05:51 +0100 [thread overview]
Message-ID: <20160209140551.GC26641@gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1602090854100.3069@macbook-air>
* Vince Weaver <vincent.weaver@maine.edu> wrote:
> On Tue, 9 Feb 2016, tip-bot for Borislav Petkov wrote:
>
> > Commit-ID: fa9cbf320e996eaa3d219344b6f7013b096cafd9
> > Gitweb: http://git.kernel.org/tip/fa9cbf320e996eaa3d219344b6f7013b096cafd9
> > Author: Borislav Petkov <bp@suse.de>
> > AuthorDate: Mon, 8 Feb 2016 17:09:04 +0100
> > Committer: Ingo Molnar <mingo@kernel.org>
> > CommitDate: Tue, 9 Feb 2016 10:23:49 +0100
> >
> > perf/x86: Move perf_event.c ............... => x86/events/core.c
> >
> > Also, keep the churn at minimum by adjusting the include "perf_event.h"
> > when each file gets moved.
>
> I have to admit I've been falling behind on my lkml reading, but is there
> a good reason for moving all these files around?
Yeah, as the PMU drivers grew organically the naming scheme became a bit messy:
- for example the uncore drivers are under kernel/cpu/, although they are not
bound to CPUs.
- separation between various vendor drivers is not always chrystal clear.
- the 'kernel/' subdirectory is a needless anachronism, we try to move bits out
of it when the opportunity presents itself.
- the new naming also better follows the core kernel/events/ perf code.
I presume after this round of patches is in, Boris will send another round to
reorganize the Intel PMU drivers as well.
> I'm often using "git blame" to track down when bugs are introduced, and it's a
> big pain trying to do that across file moves like this. Although that's maybe
> just due to difficiencies in my git usage skills.
It seems to work reasonably well here:
241771ef016b5 arch/x86/kernel/cpu/perf_counter.c (Ingo Molnar 2008-12-03 10:39:53 +0100 1) /*
cdd6c482c9ff9 arch/x86/kernel/cpu/perf_event.c (Ingo Molnar 2009-09-21 12:02:48 +0200 2) * Performance events x86 architecture code
241771ef016b5 arch/x86/kernel/cpu/perf_counter.c (Ingo Molnar 2008-12-03 10:39:53 +0100 3) *
98144511427c1 arch/x86/kernel/cpu/perf_counter.c (Ingo Molnar 2009-04-29 14:52:50 +0200 4) * Copyright (C) 2008 Thomas Gleixner <tglx@linutronix.de>
98144511427c1 arch/x86/kernel/cpu/perf_counter.c (Ingo Molnar 2009-04-29 14:52:50 +0200 5) * Copyright (C) 2008-2009 Red Hat, Inc., Ingo Molnar
98144511427c1 arch/x86/kernel/cpu/perf_counter.c (Ingo Molnar 2009-04-29 14:52:50 +0200 6) * Copyright (C) 2009 Jaswinder Singh Rajput
98144511427c1 arch/x86/kernel/cpu/perf_counter.c (Ingo Molnar 2009-04-29 14:52:50 +0200 7) * Copyright (C) 2009 Advanced Micro Devices, Inc., Robert Richter
90eec103b96e3 arch/x86/kernel/cpu/perf_event.c (Peter Zijlstra 2015-11-16 11:08:45 +0100 8) * Copyright (C) 2008-2009 Red Hat, Inc., Peter Zijlstra
30dd568c91260 arch/x86/kernel/cpu/perf_counter.c (Markus Metzger 2009-07-21 15:56:48 +0200 9) * Copyright (C) 2009 Intel Corporation, <markus.t.metzger@intel.com>
1da53e023029c arch/x86/kernel/cpu/perf_event.c (Stephane Eranian 2010-01-18 10:58:01 +0200 10) * Copyright (C) 2009 Google, Inc., Stephane Eranian
241771ef016b5 arch/x86/kernel/cpu/perf_counter.c (Ingo Molnar 2008-12-03 10:39:53 +0100 11) *
241771ef016b5 arch/x86/kernel/cpu/perf_counter.c (Ingo Molnar 2008-12-03 10:39:53 +0100 12) * For licencing details see kernel-base/COPYING
241771ef016b5 arch/x86/kernel/cpu/perf_counter.c (Ingo Molnar 2008-12-03 10:39:53 +0100 13) */
241771ef016b5 arch/x86/kernel/cpu/perf_counter.c (Ingo Molnar 2008-12-03 10:39:53 +0100 14)
[...]
c48b60538c3ba arch/x86/kernel/cpu/perf_event.c (Vince Weaver 2012-03-01 17:28:14 -0500 84) rdpmcl(hwc->event_base_rdpmc, new_raw_count);
see for example how Git still knows that we had a
arch/x86/kernel/cpu/perf_counter.c initial file name.
Or how you did an optimization in c48b60538c3ba when the file was already named
cpu/perf_event.c! :-)
Thanks,
Ingo
next prev parent reply other threads:[~2016-02-09 14:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-08 16:09 [PATCH 0/5] perf: Sanitize perf directory structure, p1 Borislav Petkov
2016-02-08 16:09 ` [PATCH 1/5] x86/events: Move perf_event.c Borislav Petkov
2016-02-09 12:17 ` [tip:perf/core] perf/x86: Move perf_event.c ............... => x86/events/core.c tip-bot for Borislav Petkov
2016-02-09 13:55 ` Vince Weaver
2016-02-09 14:00 ` Thomas Gleixner
2016-02-09 14:05 ` Ingo Molnar [this message]
2016-02-09 14:11 ` Borislav Petkov
2016-02-12 22:12 ` {SPAM?} " Vince Weaver
2016-02-08 16:09 ` [PATCH 2/5] x86/events: Move perf_event_amd.c Borislav Petkov
2016-02-09 12:17 ` [tip:perf/core] perf/x86: Move perf_event_amd.c ........... => x86/events/amd/core.c tip-bot for Borislav Petkov
2016-02-08 16:09 ` [PATCH 3/5] x86/events: Move perf_event_amd_ibs.c Borislav Petkov
2016-02-09 12:17 ` [tip:perf/core] perf/x86: Move perf_event_amd_ibs.c ....... => x86/events/amd/ibs.c tip-bot for Borislav Petkov
2016-02-08 16:09 ` [PATCH 4/5] x86/events: Move perf_event_amd_iommu.* Borislav Petkov
2016-02-09 12:18 ` [tip:perf/core] perf/x86: Move perf_event_amd_iommu.[ch] .. => x86/events/amd/iommu.[ch] tip-bot for Borislav Petkov
2016-02-08 16:09 ` [PATCH 5/5] x86/events: Move perf_event_amd_uncore.c Borislav Petkov
2016-02-09 12:18 ` [tip:perf/core] perf/x86: Move perf_event_amd_uncore.c .... => x86/events/amd/uncore.c tip-bot for Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160209140551.GC26641@gmail.com \
--to=mingo@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=bp@suse.de \
--cc=eranian@google.com \
--cc=hpa@zytor.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=vincent.weaver@maine.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).