From: Alex Williamson <alex.williamson@redhat.com>
To: Luis Henriques <luis.henriques@canonical.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Subject: Re: [PATCH] vfio: fix link failures when CONFIG_PCI_MSI is disabled
Date: Fri, 12 Feb 2016 11:17:58 -0700 [thread overview]
Message-ID: <20160212111758.4b5cb926@t450s.home> (raw)
In-Reply-To: <20160203205108.GA9181@charon.olymp>
On Wed, 3 Feb 2016 20:51:08 +0000
Luis Henriques <luis.henriques@canonical.com> wrote:
> The following link failure occurs when CONFIG_PCI_MSI is not set:
>
> drivers/built-in.o: In function `vfio_msi_set_vector_signal':
> :(.text+0x626640): undefined reference to `pci_write_msi_msg'
>
> Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
> ---
> drivers/vfio/pci/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/vfio/pci/Kconfig b/drivers/vfio/pci/Kconfig
> index 02912f180c6d..b9dbfc9aeee1 100644
> --- a/drivers/vfio/pci/Kconfig
> +++ b/drivers/vfio/pci/Kconfig
> @@ -1,6 +1,6 @@
> config VFIO_PCI
> tristate "VFIO support for PCI devices"
> - depends on VFIO && PCI && EVENTFD
> + depends on VFIO && PCI_MSI && EVENTFD
> select VFIO_VIRQFD
> select IRQ_BYPASS_MANAGER
> help
>
It seems like a better solution would be to have pci stub these out
with static inlines when !CONFIG_PCI_MSI, we already do that for quite
a lot of MSI and MSI-X callbacks. MSI/X on the device clearly won't
work if the host doesn't support MSI, and maybe there are improvements
to be made there, but MSI is a subcomponent of vfio-pci, the module
itself shouldn't depend on MSI. Thanks,
Alex
next prev parent reply other threads:[~2016-02-12 18:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-03 20:51 [PATCH] vfio: fix link failures when CONFIG_PCI_MSI is disabled Luis Henriques
2016-02-12 18:17 ` Alex Williamson [this message]
2016-02-17 15:37 ` Luis Henriques
2016-02-17 21:05 ` [PATCH] PCI/MSI: stub pci_write_msi_msg " Luis Henriques
2016-02-17 21:19 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160212111758.4b5cb926@t450s.home \
--to=alex.williamson@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=luis.henriques@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).