From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752950AbcBLOFX (ORCPT <rfc822;w@1wt.eu>);
	Fri, 12 Feb 2016 09:05:23 -0500
Received: from mx1.redhat.com ([209.132.183.28]:44580 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752919AbcBLOFR (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 12 Feb 2016 09:05:17 -0500
Date: Fri, 12 Feb 2016 15:05:06 +0100
From: Jiri Olsa <jolsa@redhat.com>
To: Wang Nan <wangnan0@huawei.com>
Cc: Alexei Starovoitov <ast@kernel.org>,
        Arnaldo Carvalho de Melo <acme@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Brendan Gregg <brendan.d.gregg@gmail.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Cody P Schafer <dev@codyps.com>,
        "David S. Miller" <davem@davemloft.net>, He Kuang <hekuang@huawei.com>,
        =?iso-8859-1?Q?J=E9r=E9mie?= Galarneau 
	<jeremie.galarneau@efficios.com>,
        Jiri Olsa <jolsa@kernel.org>, Kirill Smelkov <kirr@nexedi.com>,
        Li Zefan <lizefan@huawei.com>,
        Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>, pi3orama@163.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 09/54] perf tools: Enable passing event to BPF object
Message-ID: <20160212140506.GG16190@krava.redhat.com>
References: <1454680939-24963-1-git-send-email-wangnan0@huawei.com>
 <1454680939-24963-10-git-send-email-wangnan0@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1454680939-24963-10-git-send-email-wangnan0@huawei.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Feb 05, 2016 at 02:01:34PM +0000, Wang Nan wrote:

SNIP

> +
> +	op = bpf_map__add_newop(map);
> +	if (IS_ERR(op))
> +		return PTR_ERR(op);
> +	op->op_type = BPF_MAP_OP_SET_EVSEL;
> +	op->v.evsel = evsel;
> +	return 0;
> +}
> +
> +static int
> +bpf_map__config_event(struct bpf_map *map,
> +		      struct parse_events_term *term,
> +		      struct perf_evlist *evlist)
> +{
> +	if (!term->err_val) {
> +		pr_debug("Config value not set\n");
> +		return -BPF_LOADER_ERRNO__OBJCONF_CONF;
> +	}
> +
> +	if (!term->type_val == PARSE_EVENTS__TERM_TYPE_STR) {

this failed to compiled due to

  CC       util/bpf-loader.o
util/bpf-loader.c: In function ‘bpf_map__config_event’:
util/bpf-loader.c:1013:22: error: logical not is only applied to the left hand side of comparison [-Werror=logical-not-parentheses]
  if (!term->type_val == PARSE_EVENTS__TERM_TYPE_STR) {
                      ^
cc1: all warnings being treated as errors


jirka