From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752811AbcBLOMW (ORCPT <rfc822;w@1wt.eu>);
	Fri, 12 Feb 2016 09:12:22 -0500
Received: from mx1.redhat.com ([209.132.183.28]:53160 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752490AbcBLOMV (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 12 Feb 2016 09:12:21 -0500
Date: Fri, 12 Feb 2016 15:12:11 +0100
From: Jiri Olsa <jolsa@redhat.com>
To: Wang Nan <wangnan0@huawei.com>
Cc: Alexei Starovoitov <ast@kernel.org>,
        Arnaldo Carvalho de Melo <acme@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Brendan Gregg <brendan.d.gregg@gmail.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Cody P Schafer <dev@codyps.com>,
        "David S. Miller" <davem@davemloft.net>, He Kuang <hekuang@huawei.com>,
        =?iso-8859-1?Q?J=E9r=E9mie?= Galarneau 
	<jeremie.galarneau@efficios.com>,
        Jiri Olsa <jolsa@kernel.org>, Kirill Smelkov <kirr@nexedi.com>,
        Li Zefan <lizefan@huawei.com>,
        Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>, pi3orama@163.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 12/54] perf tools: Enable config raw and numeric events
Message-ID: <20160212141211.GJ16190@krava.redhat.com>
References: <1454680939-24963-1-git-send-email-wangnan0@huawei.com>
 <1454680939-24963-13-git-send-email-wangnan0@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1454680939-24963-13-git-send-email-wangnan0@huawei.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Feb 05, 2016 at 02:01:37PM +0000, Wang Nan wrote:
> This patch allows setting config terms for raw and numeric events.
> For example:
> 
>  # perf stat -e cycles/name=cyc/ ls
>  ...
>  1821108      cyc
>  ...
> 
>  # perf stat -e r6530160/name=event/ ls
>  ...
>  1103195      event
>  ...
> 
>  # perf record -e cycles -e 4:0x6530160/name=evtx,call-graph=fp/ -a sleep 1
>  ...
>  # perf report --stdio
>  ...
>  # Samples: 124  of event 'cycles'
>  46.61%     0.00%  swapper        [kernel.vmlinux]            [k] cpu_startup_entry
>  41.26%     0.00%  swapper        [kernel.vmlinux]            [k] start_secondary
>  ...
>  # Samples: 91  of event 'evtx'
>  ...
>  93.76%     0.00%  swapper      [kernel.vmlinux]            [k] cpu_startup_entry
>          |
>          ---cpu_startup_entry
>             |
>             |--66.63%--call_cpuidle
>             |          cpuidle_enter
>             |          |
>  ...
> 
> Signed-off-by: Wang Nan <wangnan0@huawei.com>
> Cc: He Kuang <hekuang@huawei.com>
> Cc: Alexei Starovoitov <ast@kernel.org>
> Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
> Cc: Jiri Olsa <jolsa@kernel.org>
> Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Cc: Zefan Li <lizefan@huawei.com>
> Cc: pi3orama@163.com
> ---
>  tools/perf/util/parse-events.c |  3 ++-
>  tools/perf/util/parse-events.y | 10 ++++++----
>  2 files changed, 8 insertions(+), 5 deletions(-)
> 

please add new tests into parse-events tests ;-)

Acked-by: Jiri Olsa <jolsa@kernel.org>

thanks,
jirka