From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751864AbcBLRlO (ORCPT ); Fri, 12 Feb 2016 12:41:14 -0500 Received: from foss.arm.com ([217.140.101.70]:34858 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751074AbcBLRlM (ORCPT ); Fri, 12 Feb 2016 12:41:12 -0500 Date: Fri, 12 Feb 2016 17:41:16 +0000 From: Will Deacon To: "Shi, Yang" Cc: James Morse , catalin.marinas@arm.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linaro-kernel@lists.linaro.org Subject: Re: [PATCH] arm64: make irq_stack_ptr more robust Message-ID: <20160212174116.GI17901@arm.com> References: <1455227590-9837-1-git-send-email-yang.shi@linaro.org> <56BDE260.20504@arm.com> <56BE18AB.4090902@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56BE18AB.4090902@linaro.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 12, 2016 at 09:38:51AM -0800, Shi, Yang wrote: > On 2/12/2016 5:47 AM, James Morse wrote: > >On 11/02/16 21:53, Yang Shi wrote: > >>Switching between stacks is only valid if we are tracing ourselves while on the > >>irq_stack, so it is only valid when in current and non-preemptible context, > >>otherwise is is just zeroed off. > > > >Given it was picked up with CONFIG_DEBUG_PREEMPT: > > > >Fixes: 132cd887b5c5 ("arm64: Modify stack trace and dump for use with irq_stack") > > Wii add in v2. I already queued the patch with this and the whitespace fix, so no need for a v2. Will