From: Mark Brown <broonie@kernel.org>
To: Vignesh R <vigneshr@ti.com>
Cc: Tony Lindgren <tony@atomide.com>,
Brian Norris <computersforpeace@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Russell King <linux@arm.linux.org.uk>,
hramrach@gmail.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mtd@lists.infradead.org, linux-spi@vger.kernel.org
Subject: Re: [PATCH v5 3/5] mtd: devices: m25p80: add support for mmap read request
Date: Fri, 12 Feb 2016 22:37:11 +0000 [thread overview]
Message-ID: <20160212223711.GD18988@sirena.org.uk> (raw)
In-Reply-To: <56BC1D3E.5020203@ti.com>
[-- Attachment #1: Type: text/plain, Size: 740 bytes --]
On Thu, Feb 11, 2016 at 11:03:50AM +0530, Vignesh R wrote:
> On 02/10/2016 01:06 AM, Mark Brown wrote:
> > On Fri, Dec 11, 2015 at 09:39:58AM +0530, Vignesh R wrote:
> >> + if (spi_flash_read_supported(spi)) {
> >> + struct spi_flash_read_message msg;
> >> + int ret;
> > Looking at this I can't help but think that spi_flash_read() ought to
> > have the stub in rather than the caller. But given that we're pretty
> > much only ever expecting one user I'm not 100% sure it actually matters.
> Well, my initial patch set passed long list of arguments to
> spi_flash_read(), but Brian suggested to use struct[1] in order to avoid
> unnecessary churn when things need changed in the API.
I don't see what that has to do with my point?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-02-12 22:37 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-11 4:09 [PATCH v5 0/5] Add memory mapped read support for ti-qspi Vignesh R
2015-12-11 4:09 ` [PATCH v5 1/5] spi: introduce accelerated read support for spi flash devices Vignesh R
2015-12-11 4:09 ` [PATCH v5 2/5] spi: spi-ti-qspi: add mmap mode read support Vignesh R
2015-12-11 4:09 ` [PATCH v5 3/5] mtd: devices: m25p80: add support for mmap read request Vignesh R
2016-02-09 19:36 ` Mark Brown
2016-02-11 5:33 ` Vignesh R
2016-02-12 22:37 ` Mark Brown [this message]
2016-02-16 8:00 ` Vignesh R
2016-02-16 12:38 ` Mark Brown
2016-02-17 16:11 ` R, Vignesh
2016-02-24 12:21 ` Vignesh R
2015-12-11 4:09 ` [PATCH v5 4/5] ARM: dts: DRA7: add entry for qspi mmap region Vignesh R
2015-12-11 15:09 ` Rob Herring
2015-12-17 18:45 ` Tony Lindgren
2015-12-18 5:50 ` Vignesh R
2015-12-18 16:42 ` Tony Lindgren
2015-12-11 4:10 ` [PATCH v5 5/5] ARM: dts: AM4372: " Vignesh R
2015-12-21 12:03 ` [PATCH v5 0/5] Add memory mapped read support for ti-qspi Vignesh R
2016-01-05 5:20 ` Vignesh R
2016-01-05 18:19 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160212223711.GD18988@sirena.org.uk \
--to=broonie@kernel.org \
--cc=computersforpeace@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=hramrach@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).