From: Ido Schimmel <idosch@mellanox.com>
To: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<kernel@savoirfairelinux.com>,
"David S. Miller" <davem@davemloft.net>,
Jiri Pirko <jiri@resnulli.us>, Scott Feldman <sfeldma@gmail.com>,
Nikolay Aleksandrov <nikolay@cumulusnetworks.com>,
Stephen Hemminger <stephen@networkplumber.org>,
Florian Fainelli <f.fainelli@gmail.com>,
Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH RFC 1/3] net: bridge: log state when setting it
Date: Sat, 13 Feb 2016 22:03:53 +0200 [thread overview]
Message-ID: <20160213200353.GA17193@colbert.idosch.org> (raw)
In-Reply-To: <1455312860-24666-2-git-send-email-vivien.didelot@savoirfairelinux.com>
Fri, Feb 12, 2016 at 11:34:18PM IST, vivien.didelot@savoirfairelinux.com wrote:
Hi Vivien,
>Every call to br_set_state is followed by a call to br_log_state.
>Directly call it within br_set_state instead.
>
>Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
>---
Maybe I'm missing something, but there are other instances of this
pattern throughout the code, so why not convert them as well? See
br_set_port_state() for example.
Thanks.
> net/bridge/br_stp.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
>diff --git a/net/bridge/br_stp.c b/net/bridge/br_stp.c
>index b3cca12..077afca 100644
>--- a/net/bridge/br_stp.c
>+++ b/net/bridge/br_stp.c
>@@ -52,6 +52,8 @@ void br_set_state(struct net_bridge_port *p, unsigned int state)
> if (err && err != -EOPNOTSUPP)
> br_warn(p->br, "error setting offload STP state on port %u(%s)\n",
> (unsigned int) p->port_no, p->dev->name);
>+ else
>+ br_log_state(p);
> }
>
> /* called under bridge lock */
>@@ -126,7 +128,6 @@ static void br_root_port_block(const struct net_bridge *br,
> (unsigned int) p->port_no, p->dev->name);
>
> br_set_state(p, BR_STATE_LISTENING);
>- br_log_state(p);
> br_ifinfo_notify(RTM_NEWLINK, p);
>
> if (br->forward_delay > 0)
>@@ -407,7 +408,6 @@ static void br_make_blocking(struct net_bridge_port *p)
> br_topology_change_detection(p->br);
>
> br_set_state(p, BR_STATE_BLOCKING);
>- br_log_state(p);
> br_ifinfo_notify(RTM_NEWLINK, p);
>
> del_timer(&p->forward_delay_timer);
>@@ -431,7 +431,6 @@ static void br_make_forwarding(struct net_bridge_port *p)
> else
> br_set_state(p, BR_STATE_LEARNING);
>
>- br_log_state(p);
> br_ifinfo_notify(RTM_NEWLINK, p);
>
> if (br->forward_delay != 0)
>--
>2.7.1
>
next prev parent reply other threads:[~2016-02-13 20:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-12 21:34 [PATCH RFC 0/3] net: bridge: set forwarding state when unbridging switchdev ports Vivien Didelot
2016-02-12 21:34 ` [PATCH RFC 1/3] net: bridge: log state when setting it Vivien Didelot
2016-02-13 20:03 ` Ido Schimmel [this message]
2016-02-13 21:49 ` Vivien Didelot
2016-02-12 21:34 ` [PATCH RFC 2/3] net: bridge: set forwarding state on port removal Vivien Didelot
2016-02-13 20:37 ` Ido Schimmel
2016-02-13 21:48 ` Vivien Didelot
2016-02-12 21:34 ` [PATCH RFC 3/3] net: dsa: remove dsa_slave_stp_update Vivien Didelot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160213200353.GA17193@colbert.idosch.org \
--to=idosch@mellanox.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=jiri@resnulli.us \
--cc=kernel@savoirfairelinux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=sfeldma@gmail.com \
--cc=stephen@networkplumber.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).