From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751390AbcBMUxG (ORCPT ); Sat, 13 Feb 2016 15:53:06 -0500 Received: from mail-db3on0058.outbound.protection.outlook.com ([157.55.234.58]:28832 "EHLO emea01-db3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751229AbcBMUxD (ORCPT ); Sat, 13 Feb 2016 15:53:03 -0500 Authentication-Results: savoirfairelinux.com; dkim=none (message not signed) header.d=none;savoirfairelinux.com; dmarc=none action=none header.from=mellanox.com; Date: Sat, 13 Feb 2016 22:37:38 +0200 From: Ido Schimmel To: Vivien Didelot CC: , , , "David S. Miller" , Jiri Pirko , Scott Feldman , Nikolay Aleksandrov , Stephen Hemminger , Florian Fainelli , Andrew Lunn Subject: Re: [PATCH RFC 2/3] net: bridge: set forwarding state on port removal Message-ID: <20160213203738.GB17193@colbert.idosch.org> References: <1455312860-24666-1-git-send-email-vivien.didelot@savoirfairelinux.com> <1455312860-24666-3-git-send-email-vivien.didelot@savoirfairelinux.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1455312860-24666-3-git-send-email-vivien.didelot@savoirfairelinux.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Originating-IP: [149.78.144.178] X-ClientProxiedBy: HE1PR02CA0083.eurprd02.prod.outlook.com (25.163.170.51) To DB5PR05MB0984.eurprd05.prod.outlook.com (25.161.240.14) X-Microsoft-Exchange-Diagnostics: 1;DB5PR05MB0984;2:vN6UvlweVQtk6vlT52ZkvnZVxDK2EKfUsVyyf7PgO773h8BCHAeN+cVW7kv15qFsYu60dsHc2AmsLEZcZtFhpQVYw9Et7l2mal0zkHN2ufBm3dVm2XgMXs8cm25kO2zoUgQoMm0lZaF35hxcpJhaOw==;3:biDJTwMSZ7k833l67zFJDfuo9IfVhYMQ4r5KwetfIAbDyelum69qR02QcoDIDUiUOp5EdPEojlDSmcucO5tvf0fzE4brDnnvu1mh0BWBfUubAAcKP9DG99Uss+2db8Zu;25:Hlh1Ljrr8c+ReHgSmuNXcRLJb+uIRsc2ZLtCCWJFM7QW5fCtgyF7TLPuTUXBvhtf6mYKbubPdGpZAodMdrVweVC5FFnUPleuJoiheX2XUPk1bwUhABFCtJb8KqBCs4ZK62YS081cantJ+L3Co1A/8pAU+7dhLTJCPFvETeEQhpUlnlyHlasv5hdBgHgZ/5XtyFN593RwtjNHvXk3g4Khngw90SYU0SFdeUbt2RSEGA05hK7UawUix0O1QUtODjXL+ekwLDdHMv5dsi7G16F3FqX5HsUsQKhcp1grhpXYDMFJXU6TxB4QmhuCAU+6Jll1 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB5PR05MB0984; X-MS-Office365-Filtering-Correlation-Id: dbcfb7bc-fb40-45eb-8376-08d334b5a413 X-Microsoft-Exchange-Diagnostics: 1;DB5PR05MB0984;20:qHZlD+Tld97aU/gW6xYGCU4QEroC9hIspon01yKHTtHUXUpX7cb9No3zI07SIRQxzNcJEustDYFAIc1cboDk+hZedZeowpFzZWSI1lzJjv1W3rv4BrUb5ZSkwx2AwT2ESd7r+wg3vc2bDFYwhkI77dTIpfYVy/6pTDVt3xjHuiazUYsEdoGhAr1wyf2qdK7yT8yUSz+TAN9gHiZq6ESsC66SiFQ2TABXlGDvP8cf4h+tl0Uj3C/mXkPXJ0n34G435AlKRHmCR1airk0eUR51km2HfNddHP0pbDXmLoJUyIr+J2gXRU8nhZ0kV+37cUy6L6hOzCljL1mLTj7cQq0pCS5vIZOn4DJQ0TWQrQVkoQz86+4P9esjUR2xBJu7HnMaZPHfUpMjb1XH9W7N76s+cwrgZkAfYWmFeg2QapqxnAW3vTM3jmFkdtI74lEdpG949pK4T/qutp6zV+92NX2o8V96A+ioBBpMEL9TisS2nu3+5Ah8tvl45NVtn2evDmh4;4:ZuKbyXzYAgWd1Dk/5t8AQH4nnoqxZ7uFf236Wv1k3ZBa9zpxQoEn8PBYpzgtGrrBC74hIzBG3Z9Qtu5R42Nyz5yCimW9kqcdhfzsqYVJoLfyvao9GYysuOxqcOc4xhtBxCvp2EwULVDAn5l+Pci0KYMzR7Qtnj8TyYycLcD2c9J3PbzPSkukXA5RtwdRvw0eqSIO8QPsJFkqunXqrZQwSgqrlOaBdH8oLQueNHd0pjOBOftLR7JYmjNXgYHSK3nX7PRYHIZxkh/0hG7fevBLivPR5UGPZgdHKPJlx3zv0E5t0jBiE8t9Cd6gfnk0ef7sM2z7bGdQKUpriZqcr4ObUCn3WzyFZJB0Bdz6DJU8pKLaVHafJCj2127maJFzn3vw X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001);SRVR:DB5PR05MB0984;BCL:0;PCL:0;RULEID:;SRVR:DB5PR05MB0984; X-Forefront-PRVS: 08512C5403 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(6069001)(24454002)(47776003)(1076002)(23726003)(1096002)(86362001)(87976001)(66066001)(3846002)(586003)(6116002)(97756001)(2950100001)(33656002)(42186005)(76506005)(77096005)(50466002)(40100003)(122386002)(4326007)(2906002)(50986999)(5004730100002)(76176999)(46406003)(92566002)(189998001)(54356999)(5008740100001)(110136002)(19580405001)(19580395003)(5001960100002)(4001350100001)(83506001)(217873001);DIR:OUT;SFP:1101;SCL:1;SRVR:DB5PR05MB0984;H:localhost;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;DB5PR05MB0984;23:oH99PjkSjhYbc12kO7cotgI0sV0bd5Npx40qkko5T?= =?us-ascii?Q?7atPJozSvxmGwFZzVh4ixYtbDvoZ+GXAcw9ZtyBMJmHiOjTVgJHMyLTCxoke?= =?us-ascii?Q?pM6qBlseukKQ8oJBHW5sVXJJ60B4WtQqtUQ4UCSm/57CLgbUjSVyEGZEu3k4?= =?us-ascii?Q?tfrg4ujjkd+sJdK0emwfuexVz8mdwTVXFG316tNMlw8LQUUteRzd3wkZbWxd?= =?us-ascii?Q?21X4bLWZzF1cGv/Rn3wKKhkNR+jnlmrVielmrd1egXKlcBmCtxjEM1zkaPGD?= =?us-ascii?Q?E5F6risuWumbhJHKtoIFNlxamRI+JnUrq8+QYcw6oT3Ar24hZWFI05njSIL1?= =?us-ascii?Q?OHb1eh8RZbLzpmvhIgVsAzk7tVTYFIlDKsjCa48sB+4JwbxlxZIkeffUmydT?= =?us-ascii?Q?klRLsURhoypO8oiYqV/yFLIrch/ru8U0FWeuhbP2+aNOAVYMFCn4yiYtHX7a?= =?us-ascii?Q?E3DqIbTe5ZpcS7WkLFlFeqAI14cmetA4495NsNe38RiXeX+ZlaRbCNWgssZA?= =?us-ascii?Q?WA9WnfGAlSCz/i07HIXTnPFKXKF1GJtQQg9v5iETmpSbI1rF4VvUSPm2AJ91?= =?us-ascii?Q?nChaat3r35N55OjgI+/mdTfw3Fex6cH7aa/jGTf6hWrE3p5xU187MZUmmvG5?= =?us-ascii?Q?WBTAcRFoKG7V+9sZRJ+l7g7lMBh8+TNOsUcWYmDTS5B62cNituuGox+U41CL?= =?us-ascii?Q?+L42sfZluCuH6zEzxz/DjpnNk0uwqCcsgPCR09Ek+TLukDYWlwLwah6seSnn?= =?us-ascii?Q?lXO8Z2M/hmLNAFPu6W+8QeTKeM+Vp/Y8tsbFRs2nwxprlCShvsg0CmbhTWCg?= =?us-ascii?Q?0K7Ir1b1VwCERVYdWYHtgNpUd6aKwheqMZci0liKNpWapig9hJk6mhnvdmNa?= =?us-ascii?Q?jPmKYYs90cWaw7M7rMR2xSTkZ9JCRR4Viu3THFGjP1/5oI5EpmVdOlh5JiuJ?= =?us-ascii?Q?2wvEhNQyKKn906lsTd0cZpF6v8/4FtFGdoIecuY7+MaZnKEXoypgalKPiEPq?= =?us-ascii?Q?dyEt4k4SHqrrdUHC+3cnQgwNbK+D/jd5ey/vOlfnbKY1Nmr3AEt+d7DOepO1?= =?us-ascii?Q?5thccD3C/2yS6ms4iFZuY9FwZ0+?= X-Microsoft-Exchange-Diagnostics: 1;DB5PR05MB0984;5:b2CEF3U6WWHnN9IrMHTTOCVAR4xw2B03ppK70Oa18CVmDuP73G6ltSFpIjfyn6HyZDkkApWb6ldCa28C1kCIULS8aN0vqXX+gio/Q3A90u+H+egnkEIX4yfojdTjAJZ+PDmfJ4NmgN0g/bKodFgUSg==;24:UGJ7cUtDia6r+ArnBkYIhb/kEu/ZNzH3V/r++VqTehUjW59FhfqElBaJZwQNHsMNjOu45Rn4x6FQBI/Y/TV5FYvq7vMTfh9b12N0uLwWMhU= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2016 20:38:33.0057 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR05MB0984 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fri, Feb 12, 2016 at 11:34:19PM IST, vivien.didelot@savoirfairelinux.com wrote: Hi Vivien, >When a port leaves a bridge, the bridge layer puts its STP state to >Disabled. If the port is part of an hardware switch, the mode needs to >be set to Forwarding in order to restore communication with the CPU. > >Call br_set_state() in del_nbp(), which only affects switchdev users. > >Signed-off-by: Vivien Didelot >--- If you have a LAG device in the bridge and one of the ports leaves the LAG, then the bridge's teardown sequence isn't invoked and you need to do the cleanup yourself, by calling your dsa_slave_bridge_port_leave() function (just an example, I know you don't currently support this). With this change, you'll have to call both the dsa_slave_bridge_port_leave() function and dsa_slave_stp_update() instead of always calling the same one when leaving a bridge. Also, I think this kind of things should be done by drivers, as it's specific to them. For example, in the case of a physical port, this wouldn't benefit mlxsw at all, as STP state is a per-VLAN setting and since VLANs were already flushed in nbp_vlan_flush(), then nothing would happen. Thanks! > net/bridge/br_if.c | 5 +++++ > 1 file changed, 5 insertions(+) > >diff --git a/net/bridge/br_if.c b/net/bridge/br_if.c >index c367b3e..93e7b24 100644 >--- a/net/bridge/br_if.c >+++ b/net/bridge/br_if.c >@@ -251,6 +251,11 @@ static void del_nbp(struct net_bridge_port *p) > > nbp_vlan_flush(p); > br_fdb_delete_by_port(br, p, 0, 1); >+ >+ /* If the port is part of an hardware switch, set its STP state to >+ * forwarding to restore communication with the CPU port. >+ */ >+ br_set_state(p, BR_STATE_FORWARDING); > switchdev_deferred_process(); > > nbp_update_port_count(br); >-- >2.7.1 >