From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754229AbcBPIOS (ORCPT ); Tue, 16 Feb 2016 03:14:18 -0500 Received: from mail-wm0-f53.google.com ([74.125.82.53]:34156 "EHLO mail-wm0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753961AbcBPIOR (ORCPT ); Tue, 16 Feb 2016 03:14:17 -0500 Date: Tue, 16 Feb 2016 09:14:13 +0100 From: Ingo Molnar To: Jiri Olsa Cc: Arnaldo Carvalho de Melo , lkml , David Ahern , Namhyung Kim , Peter Zijlstra Subject: Re: [PATCH 0/5] perf tools: Store CPU cache details under perf data Message-ID: <20160216081413.GA31489@gmail.com> References: <1455465826-8426-1-git-send-email-jolsa@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1455465826-8426-1-git-send-email-jolsa@kernel.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Jiri Olsa wrote: > hi, > adding support to store CPU cache details under perf data. > > $ perf report --header-only -I > ... > # cache info: > # L1 Data 32K [0-1] > # L1 Instruction 32K [0-1] > # L1 Data 32K [2-3] > # L1 Instruction 32K [2-3] > # L2 Unified 256K [0-1] > # L2 Unified 256K [2-3] > # L3 Unified 4096K [0-3] Very small UI nit, wouldn't it be nicer if this displayed tabular output, and if numbers were adjusted to their decimal point, i.e. something like: > # CPU cache info: > # L1 Data 32K [0-1] > # L1 Instruction 32K [0-1] > # L1 Data 32K [2-3] > # L1 Instruction 32K [2-3] > # L2 Unified 256K [0-1] > # L2 Unified 256K [2-3] > # L3 Unified 4096K [0-3] (Also note that it says 'CPU cache info' - there are a lot of caches in the system.) Thanks, Ingo