From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1948785AbcBSA13 (ORCPT ); Thu, 18 Feb 2016 19:27:29 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:46462 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1947882AbcBSA1D (ORCPT ); Thu, 18 Feb 2016 19:27:03 -0500 Date: Tue, 16 Feb 2016 13:42:33 +0000 From: Mark Brown To: Peter Ujfalusi Cc: Michael Turquette , Stephen Boyd , Liam Girdwood , alsa-devel@alsa-project.org, Jyri Sarha , linux-clk@vger.kernel.org, "linux-kernel@vger.kernel.org" , "Kristo, Tero" Message-ID: <20160216134233.GN18327@sirena.org.uk> References: <1455545495-20292-1-git-send-email-peter.ujfalusi@ti.com> <1455545495-20292-5-git-send-email-peter.ujfalusi@ti.com> <20160215152635.GN18988@sirena.org.uk> <56C2F00C.8080809@ti.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="qYrsQHciA3Wqs7Iv" Content-Disposition: inline In-Reply-To: <56C2F00C.8080809@ti.com> X-Cookie: Adapt. Enjoy. Survive. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 2a01:348:6:8808:7e7a:91ff:fede:4a45 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 4/4] ASoC: simple-card: Support for selecting system clocks by ID X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --qYrsQHciA3Wqs7Iv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Feb 16, 2016 at 11:46:52AM +0200, Peter Ujfalusi wrote: > As for codecs, tlv320aic3106 is also pretty simple device from the outside, it > can receive it's reference clock via: > MCLK pin, GPIO2 pin or it can use the BCLK from the bus. Based on the incoming > frequency it can use it directly or it needs to use the internal PLL to > generate the cocks. > It can output generated clock via GPIO1 That already sounds like there is room for configuration and hooking into a wider clock tree - we've got three different source options and an output plus a PLL that can presumably take in non-audio rates. > I don't think it will bring any clarity or features we miss right now if we > try to move CPU and codec drivers to clk API. IMHO. You happen to be looking at a particularly simple system but things do scale up and there's not a clear cutoff point which would allow us to make a clear distinction between things that might get used in a simple system and things that might need something more complex. This seems particularly important when we're adding things to simple-card, we want it to be usable with as many different devices as possible. --qYrsQHciA3Wqs7Iv Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWwydIAAoJECTWi3JdVIfQXAIIAIPmQaUWJVAUbw82rp0vXDYk /S7WYLF1u9HhJSbwozaC9y8wsBF2k1Xhgepr+aUjEi9eY2A/8s27BSQidnfE2PxM HDUEWO/wfJHBNqGfYh4+3IWzQ3RZsuxDzDhPRQ+cxhkPWtwv3qxOH2IE8uT3BVcB MCmzDX/VYmh/W8iXZ/il4dSFlH1PTdm+ihSr9QJR1bTF7Fseg6EzUWjCn13StYnk zszqF3k7LwXIwrpylS0BkxoMQUDZf9w2Ny8gJ6wkXK4TUq9TECi+6Xgfv+rXD/y6 sZ71fLero+zEvDY3XEtUNimSGH9zP5u2F1asBmJLxm5lWpuIREn+Cl4HZT7m3Bs= =clV+ -----END PGP SIGNATURE----- --qYrsQHciA3Wqs7Iv--