From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: Stephane Eranian <eranian@google.com>
Cc: linux-kernel@vger.kernel.org, peterz@infradead.org,
mingo@elte.hu, ak@linux.intel.com, kan.liang@intel.com,
jolsa@redhat.com, namhyung@kernel.org, adrian.hunter@intel.com,
dsahern@gmail.com
Subject: Re: [PATCH] perf/jvmti: add check for java alternatives cmd in Makefile
Date: Tue, 16 Feb 2016 12:31:26 -0200 [thread overview]
Message-ID: <20160216143126.GA8405@redhat.com> (raw)
In-Reply-To: <1455604661-9357-1-git-send-email-eranian@google.com>
Em Tue, Feb 16, 2016 at 07:37:41AM +0100, Stephane Eranian escreveu:
> This patch modifies the jvmti makefile to check
> if /usr/sbin/java-update-alternatives is present.
> If so, then use it, if not then use the altenatives
> command. This helps handle the difference between
> Ubuntu and Fedora Linux distributions.
Thanks, tested and applied.
We need tho to better integrate it with the 'make install' target, so
that it gets built and installed, this way it will end up packaged by
distros.
That, together with documentation should be enough as a first step to
ease usage in a more widespread way.
What do you think?
- Arnaldo
next prev parent reply other threads:[~2016-02-16 14:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-16 6:37 [PATCH] perf/jvmti: add check for java alternatives cmd in Makefile Stephane Eranian
2016-02-16 14:31 ` Arnaldo Carvalho de Melo [this message]
2016-02-16 14:36 ` Namhyung Kim
2016-02-16 15:55 ` Arnaldo Carvalho de Melo
2016-02-17 12:06 ` [tip:perf/core] perf jvmti: Add " tip-bot for Stephane Eranian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160216143126.GA8405@redhat.com \
--to=acme@redhat.com \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=dsahern@gmail.com \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).