From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933158AbcBPQjG (ORCPT ); Tue, 16 Feb 2016 11:39:06 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:54164 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932179AbcBPQjD (ORCPT ); Tue, 16 Feb 2016 11:39:03 -0500 Date: Tue, 16 Feb 2016 16:38:40 +0000 From: Mark Brown To: Takashi Iwai Cc: Arnd Bergmann , linux-arm-kernel@lists.infradead.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Jaroslav Kysela , Han Lu , Libin Yang , Thierry Reding , David Henningsson Message-ID: <20160216163840.GA7544@sirena.org.uk> References: <1455634059-1896914-1-git-send-email-arnd@arndb.de> <2573932.AU4HSxN0NE@wuerfel> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="AhhlLboLdkugWU4S" Content-Disposition: inline In-Reply-To: X-Cookie: This unit... must... survive. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH] sound: hdmi: avoid dereferencing uninitialized 'jack' pointer X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --AhhlLboLdkugWU4S Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Feb 16, 2016 at 05:18:29PM +0100, Takashi Iwai wrote: > Arnd Bergmann wrote: > > Another option might would be to change snd_jack_new() to return > > an error if that SND_JACK is disabled, and then require all users > > to handle the error gracefully, i.e. not fail the probe() function > > but just not use the jack. > Yes, I thought of that, too. If select is no good option, it's a good > alternative, indeed. It's going to be a bunch of work to implement though. --AhhlLboLdkugWU4S Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWw1COAAoJECTWi3JdVIfQt5EH/0aN4z4M/NgihvRMVIuOgyHd ZYxCqadzBjzKQnDhmch0qtMo+/sCo4TWoIx5FwYgB18w72z3qjZeAyFiTQiM3rgo kjhCQ1QSZT6kbLvZmj/LNjMkOsAE18NpBwsCPY+YdZEmTAPMxOsilowMsKerztVI Dw6OFytO2FwU0LWRTOU7PPlCEtRz9I5iZhfFdaGdSKNq46Y1WAmqzuW5iYazj4Fb RWvXjCiq+iLPRQVzHw30rTctot23kbHtmsr95rOhzTH8wsdvzOdPNeuKrTNy1dVe wYhfBzSduEPdJCdpjB5tC94kQgo8O8yTrYIQc9Iwj2lUSTSvlZj2Bf8XjK/BTeE= =OGKM -----END PGP SIGNATURE----- --AhhlLboLdkugWU4S--