From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933155AbcBPS6p (ORCPT ); Tue, 16 Feb 2016 13:58:45 -0500 Received: from foss.arm.com ([217.140.101.70]:56009 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752050AbcBPS6n (ORCPT ); Tue, 16 Feb 2016 13:58:43 -0500 Date: Tue, 16 Feb 2016 18:58:11 +0000 From: Mark Rutland To: Srinivas Kandagatla Cc: alsa-devel@alsa-project.org, Mark Brown , Rob Herring , Pawel Moll , Patrick Lai , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, kwestfie@codeaurora.org Subject: Re: [RFC v1 1/9] ASoC: msm8x176: Add Device Tree bindings. Message-ID: <20160216185811.GD8022@leverpostej> References: <1455643880-1611-1-git-send-email-srinivas.kandagatla@linaro.org> <1455643950-1657-1-git-send-email-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1455643950-1657-1-git-send-email-srinivas.kandagatla@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 16, 2016 at 05:32:30PM +0000, Srinivas Kandagatla wrote: > This patch adds DT bindings required for msm8x16 codec which is > integrated in msm8916 and apq8016 SOCs. > > Codec IP is divided into two parts, first analog which is integrated > in pmic pm8916 and secondly digital part which is integrated into > application processor. Codec register controls are also split across > pmic an lpass. Analog part is controlled via spmi bus to pmic, registers > on the Application processor are memory mapped. > > Signed-off-by: Srinivas Kandagatla > --- > .../devicetree/bindings/sound/qcom,msm8x16-wcd.txt | 91 ++++++++++++++++++++++ > 1 file changed, 91 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/qcom,msm8x16-wcd.txt > > diff --git a/Documentation/devicetree/bindings/sound/qcom,msm8x16-wcd.txt b/Documentation/devicetree/bindings/sound/qcom,msm8x16-wcd.txt > new file mode 100644 > index 0000000..42d3f66 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/qcom,msm8x16-wcd.txt > @@ -0,0 +1,91 @@ > +msm8x16 audio CODEC aka Tombak audio CODEC > + > +Codec IP is divided into two parts, first analog which is integrated in pmic pm8916 > +and secondly digital part which is integrated into application processor. Codec register > +controls are also split across pmic an lpass. Analog part is controlled via spmi bus to pmic. > + > +## Bindings for codec core on pmic: > + > +Required properties > + - compatible = "qcom,msm8x16-wcd-codec"; Wildcard bindings are frowned upon generally. Have separate comaptible strings, perhaps with one as a fallback for the other. > + - reg: represents the slave base address provided to the peripheral. > + - interrupt-parent : The parent interrupt controller. > + - interrupts: List of interrupts in given SPMI peripheral. > + - interrupt-names: Names specified to above list of interrupts in same > + order You must explicitly describe the set of interrupt-names for the binding. > + - vddio-supply: phandle to VDD_CDC_IO regulator device tree node. > + - vdd-tx-rx-supply: phandle to VDD_CDC_TX/RX/CX regulator device tree node. > + - vdda-cp-supply: phandle of VDD_CP charge pump supply's regulator device tree node. > + - vdda-hph-supply: phandle of VDD_HPH supply's regulator device tree node. > + - vdd-micbias-supply: phandle of VDD_MICBIAS supply's regulator device tree > + node. > +- qcom,lpass-codec-core: phandle to syscon node of lpass code core. > + > +Optional Properties: > +- qcom,micbias1-ext-cap: present if micbias1 has external capacitor connected. > +- qcom,micbias2-ext-cap: present if micbias2 has external capacitor connected. > + > +## Bindings codec core on lpass: > + > +Required properties > + - compatible: should be "syscon" follwed by "qcom,msm8x16-lpass-codec" This should be the other way around. "syscon" should be the fallback as it is the least specific. Likewise for the example. Again, wildcard bindings are generally frowned upon. Mark.