From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933260AbcBPTKc (ORCPT ); Tue, 16 Feb 2016 14:10:32 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:54314 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933241AbcBPTKU (ORCPT ); Tue, 16 Feb 2016 14:10:20 -0500 Date: Tue, 16 Feb 2016 19:09:58 +0000 From: Mark Brown To: Srinivas Kandagatla Cc: alsa-devel@alsa-project.org, Rob Herring , Mark Rutland , Pawel Moll , Patrick Lai , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, kwestfie@codeaurora.org Message-ID: <20160216190958.GD7544@sirena.org.uk> References: <1455643880-1611-1-git-send-email-srinivas.kandagatla@linaro.org> <1455643961-1700-1-git-send-email-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="NklN7DEeGtkPCoo3" Content-Disposition: inline In-Reply-To: <1455643961-1700-1-git-send-email-srinivas.kandagatla@linaro.org> X-Cookie: This unit... must... survive. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [RFC v1 2/9] ASoC: msm8x16: add driver structure X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --NklN7DEeGtkPCoo3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Feb 16, 2016 at 05:32:41PM +0000, Srinivas Kandagatla wrote: > @@ -195,7 +196,6 @@ snd-soc-wm9705-objs := wm9705.o > snd-soc-wm9712-objs := wm9712.o > snd-soc-wm9713-objs := wm9713.o > snd-soc-wm-hubs-objs := wm_hubs.o > - > # Amp > snd-soc-max9877-objs := max9877.o > snd-soc-tpa6130a2-objs := tpa6130a2.o Random whitespace change here. > + chip->micbias1_cap_mode = > + (of_property_read_bool(pdev->dev.of_node, ext1_cap) ? > + MICBIAS_EXT_BYP_CAP : MICBIAS_NO_EXT_BYP_CAP); Please don't abuse the ternery operator, write code as though people were going to read it. > + regs[0].supply = "vddio"; > + regs[1].supply = "vdd-cp"; > + regs[2].supply = "vdd-hph"; > + regs[3].supply = "vdd-tx-rx"; > + regs[4].supply = "vdd-micbias"; > + > + ret = devm_regulator_bulk_get(dev, ARRAY_SIZE(regs), regs); > + if (ret) { > + dev_err(dev, "Failed to get regulator supplies %d\n", ret); > + return ret; > + } > + chip->vddio = regs[0].consumer; > + chip->vdd_cp = regs[1].consumer; > + chip->vdd_hph = regs[2].consumer; > + chip->vdd_tx_rx = regs[3].consumer; > + chip->vdd_micbias = regs[4].consumer; Are you *sure* you should be using regulator_bulk_get() here if you never use the regulators en masse again? > +static struct snd_soc_dai_driver msm8x16_wcd_codec_dai[] = { > +}; > + > +static struct snd_soc_codec_driver msm8x16_wcd_codec = { > +}; Both empty? It seems this CODEC does nothing so may as well not have a driver... > + clk_prepare_enable(chip->mclk); Error checking. --NklN7DEeGtkPCoo3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWw3QEAAoJECTWi3JdVIfQCogH/j7JKaop/lFNqx26EQnT06Wh R8mKjg9JX6jCPhOqeZMLc5kj3lmAWPzIKfM9bksF1u0VUkc6WG693GK1k7LyHVsr YSSU/2OfSo8VDKeIPC1RfYBIR1QcZWxwiIZ9jibXcWi4pzJSwSyugCISx9Nb+2KL z7aVGRNnjCDmYVKYo3nw5flVzM6lmWDjGE8VoY3Ld6HlknPfbinqimOVmAm1A1DL TBRMEl8146qCIlV0n3HO5FRB67+QgA3jQ5VScyojOxgCPPmf68+4HurcPOXqdrxF HjY87UNloefFct60WP7MJ/kVsAfQzA5AS6pe3E3cb08ESeEPjjW8aMxZI608myo= =u8nf -----END PGP SIGNATURE----- --NklN7DEeGtkPCoo3--